chore(docs): add SECURITY.md and expand security model in ARCHITECTURE.md by abhijeet-dhumal · Pull Request #14 · kubeflow/mcp-server

abhijeet-dhumal · 2026-05-11T17:09:47Z

Description

Adds vulnerability reporting policy and expands security documentation:

Add SECURITY.md : vulnerability reporting, disclosure process (aligned with kubeflow/trainer)
Move threat model, RBAC, hardening checklist to ARCHITECTURE.md's Security Model section
Fix RBAC manifests: add create/delete/patch verbs for clustertrainingruntimes

Checklist

Tests pass locally (make test-python)
Linting passes (make verify)
Documentation updated (if applicable)
Commit messages follow conventional format

Related Issues

Fixes: #12

google-oss-prow · 2026-07-10T12:58:17Z

@abhijeet-dhumal: you cannot LGTM your own PR.

Details

In response to this:

/lgtm
/approve

SECURITY.md with threat model and RBAC guidance — CNCF readiness requirement.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

google-oss-prow · 2026-07-12T14:15:17Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from abhijeet-dhumal. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copilot

Pull request overview

Adds project security guidance covering vulnerability reporting, threat modeling, RBAC, deployment hardening, and resilience.

Changes:

Adds SECURITY.md with security and deployment guidance.
Links security and roadmap documentation from the README.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.

File	Description
`SECURITY.md`	Adds security policy, threat model, RBAC examples, and hardening checklist.
`README.md`	Adds documentation links.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+### Email
+
+- **Email:** [kubeflow-discuss@googlegroups.com](mailto:kubeflow-discuss@googlegroups.com)
+- **Subject:** `[SECURITY] kubeflow/mcp-server — <brief description>`


+The `run_custom_training` tool accepts a Python script as a string. The script is embedded inside a `train_func()` closure that is serialized by `cloudpickle` and executed **inside the Kubernetes training pod**, not on the MCP host.
+
+The `exec(compile(script, ...))` call is **deferred** — it runs inside `train_func()` at pod runtime, not at submission time on the host. However, the closure is constructed on the host and serialized, so malformed scripts could theoretically cause issues during serialization.


+
+### What the MCP Server Does NOT Control
+
+- **Kubernetes RBAC** — the server operates under the caller's permissions; it cannot grant access beyond what the Kubeconfig allows


+  # Discovery: list/get runtimes
+  - apiGroups: ["trainer.kubeflow.org"]
+    resources: ["clustertrainingruntimes"]
+    verbs: ["list", "get"]


+  - apiGroups: [""]
+    resources: ["nodes"]
+    verbs: ["list"]


+  - apiGroups: ["trainer.kubeflow.org"]
+    resources: ["trainjobs", "clustertrainingruntimes"]
+    verbs: ["list", "get"]


+roleRef:
+  apiGroup: rbac.authorization.k8s.io
+  kind: ClusterRole
+  name: kubeflow-mcp-server


Signed-off-by: abhijeet-dhumal <abhijeetdhumal652@gmail.com>

abhijeet-dhumal · 2026-07-18T10:48:57Z

@andreyvelich @thesuperzapper @astefanutti @kramaranya @szaher
Please review !
This PR is a candidate for the first mcp-server release (0.1.0) closes #12, tracking in #56.

google-oss-prow Bot requested review from andreyvelich, astefanutti and szaher May 11, 2026 17:09

google-oss-prow Bot added the size/L label May 11, 2026

abhijeet-dhumal changed the title ~~docs: add SECURITY.md with threat model, RBAC, and hardening checklist~~ chore: add SECURITY.md with threat model, RBAC, and hardening checklist May 12, 2026

abhijeet-dhumal force-pushed the add-security-context branch from 84dee52 to 1758ef5 Compare May 12, 2026 12:01

google-oss-prow Bot added the approved Approved by an approver in OWNERS label Jul 10, 2026

abhijeet-dhumal force-pushed the add-security-context branch from 1758ef5 to fbe71be Compare July 12, 2026 14:15

Copilot AI review requested due to automatic review settings July 12, 2026 14:15

google-oss-prow Bot removed the approved Approved by an approver in OWNERS label Jul 12, 2026

Copilot started reviewing on behalf of abhijeet-dhumal July 12, 2026 14:15 View session

Copilot AI reviewed Jul 12, 2026

View reviewed changes

abhijeet-dhumal changed the title ~~chore: add SECURITY.md with threat model, RBAC, and hardening checklist~~ docs: add SECURITY.md and expand security model in ARCHITECTURE.md Jul 12, 2026

abhijeet-dhumal changed the title ~~docs: add SECURITY.md and expand security model in ARCHITECTURE.md~~ chore(docs): add SECURITY.md and expand security model in ARCHITECTURE.md Jul 12, 2026

abhijeet-dhumal added 3 commits July 18, 2026 15:44

docs: add SECURITY.md with threat model, RBAC, and hardening checklist

9a58fb0

Signed-off-by: abhijeet-dhumal <abhijeetdhumal652@gmail.com>

docs: update SECURITY.md, move threat model to ARCHITECTURE.md

e0a6754

Signed-off-by: abhijeet-dhumal <abhijeetdhumal652@gmail.com>

docs: fix RBAC snippets for health_check and check_compatibility

436359d

Signed-off-by: abhijeet-dhumal <abhijeetdhumal652@gmail.com>

abhijeet-dhumal force-pushed the add-security-context branch from a3a1148 to 436359d Compare July 18, 2026 10:14

abhijeet-dhumal mentioned this pull request Jul 18, 2026

Kubeflow MCP Server 0.1.0 Release #56

Open

18 tasks

Kartikeya-trivedi mentioned this pull request Jul 18, 2026

feat(ci): replace pip-audit with OSV-Scanner for CVE detection #30

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(docs): add SECURITY.md and expand security model in ARCHITECTURE.md#14

chore(docs): add SECURITY.md and expand security model in ARCHITECTURE.md#14
abhijeet-dhumal wants to merge 3 commits into
kubeflow:mainfrom
abhijeet-dhumal:add-security-context

abhijeet-dhumal commented May 11, 2026 •

edited

Loading

Uh oh!

google-oss-prow Bot commented Jul 10, 2026

Uh oh!

google-oss-prow Bot commented Jul 12, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

abhijeet-dhumal commented Jul 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		The `run_custom_training` tool accepts a Python script as a string. The script is embedded inside a `train_func()` closure that is serialized by `cloudpickle` and executed inside the Kubernetes training pod, not on the MCP host.

		The `exec(compile(script, ...))` call is deferred — it runs inside `train_func()` at pod runtime, not at submission time on the host. However, the closure is constructed on the host and serialized, so malformed scripts could theoretically cause issues during serialization.


		### What the MCP Server Does NOT Control

		- Kubernetes RBAC — the server operates under the caller's permissions; it cannot grant access beyond what the Kubeconfig allows

Uh oh!

Conversation

abhijeet-dhumal commented May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Related Issues

Uh oh!

google-oss-prow Bot commented Jul 10, 2026

Uh oh!

google-oss-prow Bot commented Jul 12, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

abhijeet-dhumal commented Jul 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

abhijeet-dhumal commented May 11, 2026 •

edited

Loading