Skip to content

chore(ci): align pre-commit config with Kubeflow-SDK Introduced check-added-large-files#71

Merged
google-oss-prow[bot] merged 2 commits into
kubeflow:mainfrom
Raghul-M:fix/pre-commit-config-yaml
Jul 18, 2026
Merged

chore(ci): align pre-commit config with Kubeflow-SDK Introduced check-added-large-files#71
google-oss-prow[bot] merged 2 commits into
kubeflow:mainfrom
Raghul-M:fix/pre-commit-config-yaml

Conversation

@Raghul-M

Copy link
Copy Markdown
Contributor

Description

Update .pre-commit-config.yaml to match kubeflow/sdk and close the remaining gaps from #60:

  • Add check-added-large-files
  • Rename deprecated ruff hook id to ruff-check

Note: the config file already existed; this PR completes the issue requirements rather than adding it from scratch.

Related Issue

Fixes #60

Checklist

  • I have read the CONTRIBUTING guide
  • Tests pass locally (make test-python)
  • Linting passes (make verify)
  • Documentation updated (if applicable)
  • My commits are signed off (git commit -s)

Testing

  • Unit tests
  • Integration tests
  • E2E tests
  • Manually tested (describe below)

Ran uv run pre-commit run --all-files (or make verify) after the hook id change.

…-added-large-files

Signed-off-by: Raghul-M <raghul.m1430@gmail.com>
Copilot AI review requested due to automatic review settings July 12, 2026 21:04
@github-actions

Copy link
Copy Markdown

🎉 Welcome to the Kubeflow MCP Server! 🎉

Thanks for opening your first PR! We're happy to have you as part of our community 🚀

Here's what happens next:

  • If you haven't already, please check out our Contributing Guide for repo-specific guidelines and the Kubeflow Contributor Guide for general community standards
  • Our team will review your PR soon! cc @kubeflow/kubeflow-sdk-team

Join the community:

Feel free to ask questions in the comments if you need any help or clarification!
Thanks again for contributing to Kubeflow! 🙏

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns pre-commit checks with Kubeflow SDK and completes issue #60.

Changes:

  • Adds large-file validation.
  • Replaces the legacy ruff hook ID with ruff-check.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@abhijeet-dhumal

Copy link
Copy Markdown
Member

/ok-to-test

Looks good, closes the remaining #60 gaps .
Will /lgtm once pre-commit is green on the fork.

@google-oss-prow google-oss-prow Bot added the ok-to-test Approve CI for external contributors label Jul 18, 2026
@abhijeet-dhumal

abhijeet-dhumal commented Jul 18, 2026

Copy link
Copy Markdown
Member

@Raghul-M can you check unit test for pre-commit failing 👀

Signed-off-by: Raghul-M <raghul.m1430@gmail.com>
@Raghul-M

Copy link
Copy Markdown
Contributor Author

@Raghul-M can you check unit test for pre-commit failing 👀

fixed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@abhijeet-dhumal

Copy link
Copy Markdown
Member

/lgtm
/approve
Thanks @Raghul-M for your contribution !🚀

@google-oss-prow google-oss-prow Bot added the lgtm Looks good to me — approved by a reviewer label Jul 18, 2026
@google-oss-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhijeet-dhumal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow Bot added the approved Approved by an approver in OWNERS label Jul 18, 2026
@google-oss-prow
google-oss-prow Bot merged commit cc858d7 into kubeflow:main Jul 18, 2026
12 of 13 checks passed
@google-oss-prow google-oss-prow Bot added this to the v0.1 milestone Jul 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Approved by an approver in OWNERS lgtm Looks good to me — approved by a reviewer ok-to-test Approve CI for external contributors size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: Add .pre-commit-config.yaml

3 participants