Skip to content

chore(ci): add workflow to validate uv.lock and check for regressions#73

Merged
google-oss-prow[bot] merged 1 commit into
kubeflow:mainfrom
priyank766:feat/validate-lockfile
Jul 18, 2026
Merged

chore(ci): add workflow to validate uv.lock and check for regressions#73
google-oss-prow[bot] merged 1 commit into
kubeflow:mainfrom
priyank766:feat/validate-lockfile

Conversation

@priyank766

Copy link
Copy Markdown
Contributor

Description

Adds a CI workflow (validate-lockfile.yaml) that triggers on pull requests when uv.lock or pyproject.toml are modified.

The workflow performs two checks:

  1. Sync Check: Ensures the uv.lock file is fully in sync with pyproject.toml using uv lock --check.
  2. Security Regression Check: Audits the PR branch and base branch using uv audit, compares the results, and posts a warning comment on the PR detailing any newly introduced vulnerabilities.

This follows the established pattern in kubeflow/sdk to prevent merging stale or insecure lockfiles.

Related Issue

Fixes #61

Testing

  • Unit tests
  • Integration tests
  • E2E tests
  • Manually tested (describe below)

Manually verified uv lock --check runs successfully on the local environment.

Copilot AI review requested due to automatic review settings July 13, 2026 10:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

Copy link
Copy Markdown

🎉 Welcome to the Kubeflow MCP Server! 🎉

Thanks for opening your first PR! We're happy to have you as part of our community 🚀

Here's what happens next:

  • If you haven't already, please check out our Contributing Guide for repo-specific guidelines and the Kubeflow Contributor Guide for general community standards
  • Our team will review your PR soon! cc @kubeflow/kubeflow-sdk-team

Join the community:

Feel free to ask questions in the comments if you need any help or clarification!
Thanks again for contributing to Kubeflow! 🙏

@priyank766 priyank766 changed the title ci: add workflow to validate uv.lock and check for regressions chore(ci): add workflow to validate uv.lock and check for regressions Jul 13, 2026
@priyank766
priyank766 force-pushed the feat/validate-lockfile branch from a1bd074 to 2176076 Compare July 13, 2026 10:21
@priyank766

Copy link
Copy Markdown
Contributor Author

@Krishna-kg732 is there any suggestions on this ?? i saw the notification from your side but comment is removed ig!

@Krishna-kg732

Copy link
Copy Markdown

no , i had added a comment and then reomved it.

@abhijeet-dhumal

Copy link
Copy Markdown
Member

/ok-to-test

@google-oss-prow google-oss-prow Bot added the ok-to-test Approve CI for external contributors label Jul 18, 2026
@abhijeet-dhumal

Copy link
Copy Markdown
Member

Thanks @priyank766 , Looks good ! t
This PR tracks the kubeflow/sdk validate-lockfile pattern and closes #61.

One ask before merge: can you rebase on latest main, bump astral-sh/setup-uv from v4 to v7 (matches sdk's pattern as well as recently merged Dependabot bumps in this repo).

Btw have you tested this PR? Could you either temporarily drop the path filter for one push or touch pyproject.toml on your fork so we see a green check-security-regressions run?

@priyank766
priyank766 force-pushed the feat/validate-lockfile branch from 2176076 to af437d8 Compare July 18, 2026 12:25
@priyank766

Copy link
Copy Markdown
Contributor Author

Updated setup-uv to v7, and touched pyproject.toml. All checks are green now!
@abhijeet-dhumal

Comment thread pyproject.toml Outdated
Signed-off-by: priyank <priyank8445@gmail.com>
@priyank766
priyank766 force-pushed the feat/validate-lockfile branch from af437d8 to b0e8210 Compare July 18, 2026 13:50
@abhijeet-dhumal

Copy link
Copy Markdown
Member

/lgtm
/approve
Thanks @priyank766 for your contribution, this is great work 🚀

@google-oss-prow google-oss-prow Bot added the lgtm Looks good to me — approved by a reviewer label Jul 18, 2026
@google-oss-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhijeet-dhumal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow Bot added the approved Approved by an approver in OWNERS label Jul 18, 2026
@google-oss-prow
google-oss-prow Bot merged commit 99d85e9 into kubeflow:main Jul 18, 2026
12 of 13 checks passed
@google-oss-prow google-oss-prow Bot added this to the v0.1 milestone Jul 18, 2026
@priyank766
priyank766 deleted the feat/validate-lockfile branch July 18, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Approved by an approver in OWNERS lgtm Looks good to me — approved by a reviewer ok-to-test Approve CI for external contributors size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: Add validate-lockfile workflow

4 participants