Skip to content

chore: added pre-commit to dev dependency group#86

Merged
google-oss-prow[bot] merged 1 commit into
kubeflow:mainfrom
Shaurya2k06:refactor/pre-commit
Jul 18, 2026
Merged

chore: added pre-commit to dev dependency group#86
google-oss-prow[bot] merged 1 commit into
kubeflow:mainfrom
Shaurya2k06:refactor/pre-commit

Conversation

@Shaurya2k06

Copy link
Copy Markdown
Contributor

Description

This pull request adds a new development dependency to the project. The pre-commit tool is now included in the dev dependency group to help automate code quality checks before commits.

Development tooling:

  • Added pre-commit>=4.2.0 to the dev dependency group in pyproject.toml to enable automated pre-commit hooks for code quality.

Related Issue

Fixes #85

Checklist

  • I have read the CONTRIBUTING guide
  • Tests pass locally (make test-python)
  • Linting passes (make verify)
  • Documentation updated (if applicable)
  • My commits are signed off (git commit -s)

Testing

  • Unit tests
  • Integration tests
  • E2E tests
  • Manually tested (describe below)

Copilot AI review requested due to automatic review settings July 16, 2026 15:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

Copy link
Copy Markdown

🎉 Welcome to the Kubeflow MCP Server! 🎉

Thanks for opening your first PR! We're happy to have you as part of our community 🚀

Here's what happens next:

  • If you haven't already, please check out our Contributing Guide for repo-specific guidelines and the Kubeflow Contributor Guide for general community standards
  • Our team will review your PR soon! cc @kubeflow/kubeflow-sdk-team

Join the community:

Feel free to ask questions in the comments if you need any help or clarification!
Thanks again for contributing to Kubeflow! 🙏

@Shaurya2k06 Shaurya2k06 changed the title Chore: Added Pre-commit to dev dependency group chore: added pre-commit to dev dependency group Jul 16, 2026
@Krishna-kg732

Copy link
Copy Markdown

Hey @Shaurya2k06 , thanks for the fast fix

/lgtm

cc : @abhijeet-dhumal

@google-oss-prow google-oss-prow Bot added the lgtm Looks good to me — approved by a reviewer label Jul 16, 2026
@abhijeet-dhumal

Copy link
Copy Markdown
Member

/ok-to-test

@google-oss-prow google-oss-prow Bot added the ok-to-test Approve CI for external contributors label Jul 17, 2026
@Shaurya2k06
Shaurya2k06 force-pushed the refactor/pre-commit branch from 11f9ac4 to d2fa022 Compare July 17, 2026 08:40
@google-oss-prow google-oss-prow Bot removed the lgtm Looks good to me — approved by a reviewer label Jul 17, 2026
Signed-off-by: shaurya2k06 <shaurya2k06@gmail.com>
@Shaurya2k06
Shaurya2k06 force-pushed the refactor/pre-commit branch from d2fa022 to 8cec1f9 Compare July 17, 2026 09:06
@google-oss-prow google-oss-prow Bot added size/L and removed size/XS labels Jul 17, 2026
@Krishna-kg732

Copy link
Copy Markdown

Thanks

/lgtm

@google-oss-prow google-oss-prow Bot added the lgtm Looks good to me — approved by a reviewer label Jul 17, 2026
@abhijeet-dhumal

Copy link
Copy Markdown
Member

/lgtm
/approve
Thanks @Shaurya2k06 for your contribution ! 🚀

@google-oss-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhijeet-dhumal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow Bot added the approved Approved by an approver in OWNERS label Jul 18, 2026
@google-oss-prow
google-oss-prow Bot merged commit 773b0e9 into kubeflow:main Jul 18, 2026
14 checks passed
@google-oss-prow google-oss-prow Bot added this to the v0.1 milestone Jul 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Approved by an approver in OWNERS lgtm Looks good to me — approved by a reviewer ok-to-test Approve CI for external contributors size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(ci): pre-commit is missing from dev dependencies in pyproject.toml

4 participants