Skip to content

fix(nb): fixed missing reference in crud-web-apps volumes backend#770

Open
mathis-marcotte wants to merge 1 commit intokubeflow:notebooks-v1from
mathis-marcotte:fix-volumes-reference
Open

fix(nb): fixed missing reference in crud-web-apps volumes backend#770
mathis-marcotte wants to merge 1 commit intokubeflow:notebooks-v1from
mathis-marcotte:fix-volumes-reference

Conversation

@mathis-marcotte
Copy link

I noticed that the "delete_pvc" endpoint was referencing a missing value from the "viewer_utils" import.

When running that code, it would result in this error:

Traceback (most recent call last):
  File "/home/marcoma/Documents/upstreams/kubeflow/components/crud-web-apps/volumes/backend/web-apps-dev/lib/python3.10/site-packages/flask/app.py", line 917, in full_dispatch_request
    rv = self.dispatch_request()
  File "/home/marcoma/Documents/upstreams/kubeflow/components/crud-web-apps/volumes/backend/web-apps-dev/lib/python3.10/site-packages/flask/app.py", line 902, in dispatch_request
    return self.ensure_sync(self.view_functions[rule.endpoint])(**view_args)  # type: ignore[no-any-return]
  File "/home/marcoma/Documents/upstreams/kubeflow/components/crud-web-apps/volumes/backend/apps/default/routes/delete.py", line 30, in delete_pvc
    viewer_utils.VIEWER_LABEL,
AttributeError: module 'apps.common.viewer' has no attribute 'VIEWER_LABEL'

So I replaced it for a value that does exist. Please confirm if this was the original intent for this warning log.

Original PR here: kubeflow/kubeflow#7718

Signed-off-by: Mathis Marcotte <84033116+mathis-marcotte@users.noreply.github.com>
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign thesuperzapper for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot added the area/backend area - related to backend components label Dec 4, 2025
@google-oss-prow google-oss-prow bot added area/frontend area - related to frontend components area/v1 area - version - kubeflow notebooks v1 size/XS labels Dec 4, 2025
@github-actions
Copy link

github-actions bot commented Feb 3, 2026

This pull request has been automatically marked as stale because it has not had recent activity.
It will be closed if no further activity occurs.
Thank you for your contributions.

Members may comment /lifecycle frozen to prevent this pull request from being marked as stale.

@mathis-marcotte
Copy link
Author

/lifecycle frozen

@google-oss-prow
Copy link

@mathis-marcotte: The lifecycle/frozen label cannot be applied to Pull Requests.

Details

In response to this:

/lifecycle frozen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/backend area - related to backend components area/frontend area - related to frontend components area/v1 area - version - kubeflow notebooks v1 size/XS

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

1 participant