fix(trainer): return TRAINJOB_COMPLETE when all steps are done

[priyank766]

What this PR does / why we need it:
LocalProcessBackend.__get_job_status() returns TRAINJOB_CREATED when all steps have finished, instead of TRAINJOB_COMPLETE. This causes wait_for_job_status() to always timeout (600s) on the local backend even when jobs complete successfully. This is a one-line fix in the else branch to return the correct status.

Which issue(s) this PR fixes:

Fixes #338, #315

Checklist:

• Docs included if any changes are user facing

[github-actions]

🎉 Welcome to the Kubeflow SDK! 🎉

Thanks for opening your first PR! We're happy to have you as part of our community 🚀

Here's what happens next:

• If you haven't already, please check out our Contributing Guide for repo-specific guidelines and the Kubeflow Contributor Guide for general community standards
• Our team will review your PR soon! cc @kubeflow/kubeflow-sdk-team

Join the community:

• Slack: Join our #kubeflow-ml-experience and #kubeflow-trainer Slack channels
• Meetings: Attend the Kubeflow SDK and ML Experience bi-weekly meetings

Feel free to ask questions in the comments if you need any help or clarification!
Thanks again for contributing to Kubeflow! 🙏

[Copilot]

Pull request overview

This PR fixes a one-line bug in LocalProcessBackend.__get_job_status() where the else branch (reached when all steps are in TRAINJOB_COMPLETE state) incorrectly returned TRAINJOB_CREATED instead of TRAINJOB_COMPLETE. This caused wait_for_job_status() to always time out (after 600 seconds) on the local backend, even for successfully completed jobs.

Changes:

• Fix the else branch of __get_job_status to return TRAINJOB_COMPLETE instead of TRAINJOB_CREATED when all steps have finished successfully.

[priyank766]

@andreyvelich
@astefanutti
@jaiakash

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

[Fiona-Waters]

/ok-to-test

[priyank766]

@Fiona-Waters added a test case for TRAINJOB
And E2E test are solved

[Fiona-Waters]

Thanks @priyank766 for adding the test. Just one other comment

[Fiona-Waters]

Thanks @priyank766
/lgtm

[priyank766]

Welcome @Fiona-Waters
#313 I had created this PR and got the
/ok-to-test to it and all E2E test ran successfully
But then there was a Maintainer for review it
Maybe if you can check it

[andreyvelich]

Thanks @priyank766!
/lgtm
/approve

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [andreyvelich]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment