docs: add KEP-2839 Dynamic LLM Trainer Framework proposal#3263
Draft
NarayanaSabari wants to merge 4 commits intokubeflow:masterfrom
Draft
docs: add KEP-2839 Dynamic LLM Trainer Framework proposal#3263NarayanaSabari wants to merge 4 commits intokubeflow:masterfrom
NarayanaSabari wants to merge 4 commits intokubeflow:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
🎉 Welcome to the Kubeflow Trainer! 🎉 Thanks for opening your first PR! We're happy to have you as part of our community 🚀 Here's what happens next:
Join the community:
Feel free to ask questions in the comments if you need any help or clarification! |
- Strip all Low-Level Design content (code interfaces, strategies, Dockerfile, runtime YAML, Helm chart details) - Fix 10 technical inaccuracies found during audit: - TRL CLI entry point (trl sft, not python -m trl) - Multi-node env vars (standard + PET variants) - Correct enforceTorchTunePolicy inline location - dependsOn YAML format, volume handling pattern - TRLTrainerType enum values (SFT/DPO/KTO/GRPO) - Container name 'node' not 'trainer' - PET env var naming conventions - KEP now covers: Summary, Goals, Non-Goals, Current State Analysis, High-Level Design, Test Plan, Risks, Phases
Signed-off-by: Sabari Narayana <sabarinarayanakg@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add KEP-2839: Dynamic LLM Trainer Framework proposal.
This KEP proposes decoupling the
BuiltinTrainerfrom TorchTune by introducing a pluggableLLMBackendinterface in the Python SDK and a correspondingLLMBackendStrategyin the Gocontrol plane. TorchTune becomes the first backend implementation (preserving backward
compatibility), and TRL is added as the first new backend with SFT/DPO support.
Builds on KEP-2401
and the community consensus on "Plan 3" from #2752.
Tracking issue: #2839
What This KEP Covers
SDK (Python)
LLMBackendabstract base class withto_command(),to_args(),framework(),validate()@register_backenddecorator supporting external/out-of-tree backendsBuiltinTrainer.configtype widened fromTorchTuneConfigtoLLMBackendTorchTuneConfigrefactored to implementLLMBackend(zero breaking changes)TRLConfigbackend with SFT and DPO trainer typesGo Control Plane
LLMBackendStrategyinterface replacing hardcoded TorchTune command-sniffing in the Torch pluginTorchTuneStrategy(wraps existingtorchtune.gologic unchanged)TRLStrategy(minimal -- TRL config is fully constructed by the SDK)trainer.kubeflow.org/frameworklabel on ClusterTrainingRuntimeInfrastructure
cmd/trainers/trl/)manifests/base/runtimes/trl/)Non-Goals
Test Plan
TorchTuneConfigbackward compat,TRLConfig, Go strategy dispatch/cc @Electronic-Waste @andreyvelich @tariq-hasan