Fix Watch follow parameter detection#2616
Conversation
The generated client now emits parameter names and types on separate lines. Watch still searches for the old combined line, so it sends watch=True to pod log methods and the generated client rejects the unexpected keyword. Match the current generated format and update the fixture that covers log streaming.
|
Welcome @tamird! |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tamird The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
OpenAPI-generated methods now document parameter names and types on separate
lines.
Watchstill looked for the previous combined:param bool follow:form, so it sent
watch=Trueto pod log methods. Those methods reject theunexpected keyword instead of streaming logs.
Match the generated
:param follow:form and update the existing test fixtureto use the current generated docstring shape.
Which issue(s) this PR fixes:
Fixes #2615
Special notes for your reviewer:
None.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: