Validate instance group names in kops-controller#18391
Merged
Merged
Conversation
k8s-ci-robot
added
size/M
hakman
approved these changes
May 21, 2026
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Member
|
/retest |
This was referenced May 21, 2026
k8s-ci-robot
added a commit
that referenced
this pull request
May 21, 2026
…91-origin-release-1.34 Automated cherry pick of #18391: Validate instance group names in kops-controller
k8s-ci-robot
added a commit
that referenced
this pull request
May 21, 2026
…91-origin-release-1.35 Automated cherry pick of #18391: Validate instance group names in kops-controller
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InstanceGroup names are Kubernetes ObjectMeta names and should follow the DNS-subdomain rule the API server enforces on every other ObjectMeta. The kops validation package already centralizes rules of this shape (cluster names, etc.), but there was no equivalent helper for InstanceGroup names — each call site was either reimplementing the check or skipping it. kops-controller in particular was using the IG name from the verified node identity as a path component when resolving
igconfig/node/<name>/nodeupconfig.yamlwithout validating its shape first.(Opus 4.7)
/cc @hakman