Precompile log buffer regular expressions#1323
Merged
kubernetes-prow[bot] merged 1 commit intoJul 26, 2026
Merged
Conversation
kubernetes-prow
Bot
added
cncf-cla: yes
DigitalVeer
reviewed
Jul 22, 2026
DigitalVeer
left a comment
DigitalVeer
left a comment
Contributor
There was a problem hiding this comment.
nice! glad we're moving pattern compilation to startup now :) - a few catches
Compile fixed patterns during monitor and log counter initialization, pass compiled expressions to the log buffer, and reject invalid log counter patterns before watching logs.
hakman
force-pushed
the
precompile-log-buffer-regexps
branch
from
July 25, 2026 06:21
2a4daab to
b02e2dc
Compare
Member
Author
|
/cc @ameukam |
Member
|
/lgtm |
kubernetes-prow
Bot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ameukam, hakman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compile fixed patterns during monitor and log counter initialization, pass compiled expressions to the log buffer, and reject invalid log counter patterns before watching logs.
/cc @wangzhen127 @ameukam