Fix version mismatch between staging and pushing artifacts#4310
Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom Mar 5, 2026
Merged
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
approved
k8s-ci-robot
added
the
cncf-cla: yes
saschagrunert
force-pushed
the
fix-push-version-mismatch
branch
from
362d7f1 to
5dee51b
Compare
k8s-ci-robot
added
release-note
saschagrunert
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
When the version is auto-discovered (no --version flag), findLatestVersion() resolves the version and appends the version suffix, but never updates bi.opts.Version. This causes StageLocalArtifacts() to use an empty version path while PushReleaseArtifacts() uses the resolved version, resulting in a "no such file or directory" error. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
force-pushed
the
fix-push-version-mismatch
branch
from
5dee51b to
2180bcc
Compare
saschagrunert
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
saschagrunert
added
the
priority/critical-urgent
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
krel pushfailing when the version is auto-discovered (no--versionflag) and--version-suffixis usedfindLatestVersion()resolves the version and appends the suffix but never updatesbi.opts.Version, causingStageLocalArtifacts()to stage to a path without the version whilePushReleaseArtifacts()looks for it with the versionWhich issue(s) this PR fixes:
None
Special notes for your reviewer:
This was discovered via kubernetes/perf-tests#3845 which broke the
build-and-push-k8s-at-golang-tipjob: https://testgrid.k8s.io/sig-scalability-golang#build-and-push-k8s-at-golang-tipcc @rf232 @kubernetes/release-managers
Does this PR introduce a user-facing change?