Skip to content

chore: bump armoapi-go for reason codes, Error field, ReasonFriendlyText#100

Merged
kooomix merged 1 commit intomainfrom
feature/SUB-7105-scan-failure-notification
Mar 29, 2026
Merged

chore: bump armoapi-go for reason codes, Error field, ReasonFriendlyText#100
kooomix merged 1 commit intomainfrom
feature/SUB-7105-scan-failure-notification

Conversation

@kooomix
Copy link
Copy Markdown
Contributor

@kooomix kooomix commented Mar 29, 2026

Summary

Bump armoapi-go to pick up scan failure notification enhancements from armosec/armoapi-go#625:

  • 12 Reason* constants (enum-like codes for scan failure notifications)
  • Error field on ScanFailureReport (R&D debugging, not user-facing)
  • ReasonFriendlyText() for UNS notification rendering
  • ReasonScannerOOMKilled and ReasonScanTimeout for sidecar-specific failures

Since ScanFailureOnFinishedMessage embeds ScanFailureReport, this bump ensures the Error field flows through event-ingester to UNS.

Related

Summary by CodeRabbit

  • Chores
    • Updated a project dependency to a newer release to keep libraries current. This change refreshes underlying tooling for improved stability, maintenance, and future compatibility; it does not alter public APIs or exported behavior and has no user-facing feature changes.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 29, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 06675c5e-956c-4c8c-888b-6dcc52a1eba3

📥 Commits

Reviewing files that changed from the base of the PR and between 4876bc8 and f6c521c.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod
✅ Files skipped from review due to trivial changes (1)
  • go.mod

📝 Walkthrough

Walkthrough

The pull request updates the github.com/armosec/armoapi-go dependency version in go.mod from v0.0.690 to v0.0.694. No other modules or direct dependencies are affected.

Changes

Cohort / File(s) Summary
Dependency Version Update
go.mod
Bumped github.com/armosec/armoapi-go from v0.0.690 to v0.0.694 (single-line version change).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • bvolovat

Poem

🐰 A hop, a bump, a version new,
I swapped one number — quick and true.
No files changed, just tidy lines,
A rabbit cheers in tiny rhymes. ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: bumping armoapi-go dependency and mentions the key features being added (reason codes, Error field, ReasonFriendlyText).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/SUB-7105-scan-failure-notification

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Summary:

  • License scan: failure
  • Credentials scan: skipped
  • Vulnerabilities scan: skipped
  • Unit test: success
  • Go linting: success

Bump to pick up:
- 12 Reason* constants (enum-like codes for scan failure notifications)
- Error field on ScanFailureReport (R&D debugging)
- ReasonFriendlyText() for UNS notification rendering

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@kooomix kooomix force-pushed the feature/SUB-7105-scan-failure-notification branch from 4876bc8 to f6c521c Compare March 29, 2026 15:07
@kooomix kooomix merged commit 943bf45 into main Mar 29, 2026
6 checks passed
@github-actions
Copy link
Copy Markdown

Summary:

  • License scan: failure
  • Credentials scan: skipped
  • Vulnerabilities scan: skipped
  • Unit test: success
  • Go linting: success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants