Skip to content

add ECS cluster user input commands#95

Merged
YakirOren merged 1 commit intomainfrom
feature/ecs-connection
Feb 23, 2026
Merged

add ECS cluster user input commands#95
YakirOren merged 1 commit intomainfrom
feature/ecs-connection

Conversation

@YakirOren
Copy link
Copy Markdown
Contributor

@YakirOren YakirOren commented Feb 22, 2026

Add create/delete ECS cluster commands.

Summary by CodeRabbit

  • New Features
    • Added new command actions to support creating and deleting ECS clusters from the user input interface, enabling users to manage ECS cluster lifecycle via existing command workflows.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 22, 2026

📝 Walkthrough

Walkthrough

Two new exported constants were added to the user input command list for ECS cluster operations: UserInputCommandCreateECSCluster ("create-ecs-cluster") and UserInputCommandDeleteECSCluster ("delete-ecs-cluster"), placed under an ECS cluster actions section.

Changes

Cohort / File(s) Summary
ECS Cluster Commands
pulsar/common/userinput/commands.go
Added two new UserInputCommand constants: UserInputCommandCreateECSCluster ("create-ecs-cluster") and UserInputCommandDeleteECSCluster ("delete-ecs-cluster") under an ECS cluster actions section.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A hop, a tweak, two names appear,

Create and Delete, both crystal clear,
ECS fields now have new light,
Constants snug, tucked in just right,
Hooray — a tiny change, but cheer! 🎉

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'add ECS cluster user input commands' directly and accurately describes the main change: adding two new ECS cluster commands (create and delete) to the user input commands.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/ecs-connection

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Summary:

  • License scan: failure
  • Credentials scan: skipped
  • Vulnerabilities scan: skipped
  • Unit test: success
  • Go linting: success

Signed-off-by: Yakir Oren <yakiroren@gmail.com>
@YakirOren YakirOren force-pushed the feature/ecs-connection branch from daaeb26 to 1af7bc0 Compare February 22, 2026 16:06
Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
pulsar/common/userinput/commands.go (1)

123-125: Consider whether UserInputCommandUpdateECSCluster is intentionally omitted.

Every other multi-operation resource group in this file follows a create/update/delete triad (Workflow, Registry, TeamsChannel, CloudAccount, SavedFilter, Webhook, SIEM Integration, etc.). ECS cluster only defines create and delete. If in-place updates to ECS clusters are not supported by the underlying design, this is fine — but if an update path exists or is planned, the constant belongs here for symmetry.

➕ Proposed addition if an update operation is needed
 	// ECS cluster actions
 	UserInputCommandCreateECSCluster = UserInputCommand("create-ecs-cluster")
+	UserInputCommandUpdateECSCluster = UserInputCommand("update-ecs-cluster")
 	UserInputCommandDeleteECSCluster = UserInputCommand("delete-ecs-cluster")
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@pulsar/common/userinput/commands.go` around lines 123 - 125, The file defines
UserInputCommandCreateECSCluster and UserInputCommandDeleteECSCluster but omits
UserInputCommandUpdateECSCluster; if ECS clusters support in-place updates add a
new constant UserInputCommandUpdateECSCluster =
UserInputCommand("update-ecs-cluster") alongside the existing constants and then
register/handle it in the same places that use the other ECS command constants
(e.g., command dispatch/switch blocks, maps, or validation lists that reference
UserInputCommandCreateECSCluster and UserInputCommandDeleteECSCluster) so the
update flow is recognized end-to-end.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@pulsar/common/userinput/commands.go`:
- Around line 123-125: The file defines UserInputCommandCreateECSCluster and
UserInputCommandDeleteECSCluster but omits UserInputCommandUpdateECSCluster; if
ECS clusters support in-place updates add a new constant
UserInputCommandUpdateECSCluster = UserInputCommand("update-ecs-cluster")
alongside the existing constants and then register/handle it in the same places
that use the other ECS command constants (e.g., command dispatch/switch blocks,
maps, or validation lists that reference UserInputCommandCreateECSCluster and
UserInputCommandDeleteECSCluster) so the update flow is recognized end-to-end.

@github-actions
Copy link
Copy Markdown

Summary:

  • License scan: failure
  • Credentials scan: skipped
  • Vulnerabilities scan: skipped
  • Unit test: success
  • Go linting: success

@YakirOren YakirOren merged commit f247111 into main Feb 23, 2026
8 checks passed
@matthyx matthyx deleted the feature/ecs-connection branch February 23, 2026 20:51
@matthyx matthyx moved this to To Archive in KS PRs tracking Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants