Conversation
📝 WalkthroughWalkthroughTwo new exported constants were added to the user input command list for ECS cluster operations: Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Summary:
|
Signed-off-by: Yakir Oren <yakiroren@gmail.com>
daaeb26 to
1af7bc0
Compare
There was a problem hiding this comment.
🧹 Nitpick comments (1)
pulsar/common/userinput/commands.go (1)
123-125: Consider whetherUserInputCommandUpdateECSClusteris intentionally omitted.Every other multi-operation resource group in this file follows a create/update/delete triad (Workflow, Registry, TeamsChannel, CloudAccount, SavedFilter, Webhook, SIEM Integration, etc.). ECS cluster only defines create and delete. If in-place updates to ECS clusters are not supported by the underlying design, this is fine — but if an update path exists or is planned, the constant belongs here for symmetry.
➕ Proposed addition if an update operation is needed
// ECS cluster actions UserInputCommandCreateECSCluster = UserInputCommand("create-ecs-cluster") + UserInputCommandUpdateECSCluster = UserInputCommand("update-ecs-cluster") UserInputCommandDeleteECSCluster = UserInputCommand("delete-ecs-cluster")🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pulsar/common/userinput/commands.go` around lines 123 - 125, The file defines UserInputCommandCreateECSCluster and UserInputCommandDeleteECSCluster but omits UserInputCommandUpdateECSCluster; if ECS clusters support in-place updates add a new constant UserInputCommandUpdateECSCluster = UserInputCommand("update-ecs-cluster") alongside the existing constants and then register/handle it in the same places that use the other ECS command constants (e.g., command dispatch/switch blocks, maps, or validation lists that reference UserInputCommandCreateECSCluster and UserInputCommandDeleteECSCluster) so the update flow is recognized end-to-end.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@pulsar/common/userinput/commands.go`:
- Around line 123-125: The file defines UserInputCommandCreateECSCluster and
UserInputCommandDeleteECSCluster but omits UserInputCommandUpdateECSCluster; if
ECS clusters support in-place updates add a new constant
UserInputCommandUpdateECSCluster = UserInputCommand("update-ecs-cluster")
alongside the existing constants and then register/handle it in the same places
that use the other ECS command constants (e.g., command dispatch/switch blocks,
maps, or validation lists that reference UserInputCommandCreateECSCluster and
UserInputCommandDeleteECSCluster) so the update flow is recognized end-to-end.
|
Summary:
|
Add create/delete ECS cluster commands.
Summary by CodeRabbit