Skip to content

feat: add ScanFailureTopic constant#96

Merged
kooomix merged 1 commit intomainfrom
feature/scan-failure-topic
Mar 8, 2026
Merged

feat: add ScanFailureTopic constant#96
kooomix merged 1 commit intomainfrom
feature/scan-failure-topic

Conversation

@kooomix
Copy link
Copy Markdown
Contributor

@kooomix kooomix commented Mar 8, 2026

Summary

  • Add ScanFailureTopic = "scan-failure-v1" constant to pulsar/common/topics.go
  • Used by careportsreceiver for scan failure report publishing

Jira: SUB-7074

Test plan

  • go build ./... passes

Summary by CodeRabbit

  • New Features
    • Added support for scan failure event handling and reporting.

Add scan-failure-v1 Pulsar topic for generic scan failure reporting.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 8, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 07ac9d97-979f-4da8-a4f3-2850e917a65a

📥 Commits

Reviewing files that changed from the base of the PR and between f247111 and 5c88789.

📒 Files selected for processing (1)
  • pulsar/common/topics.go

📝 Walkthrough

Walkthrough

A new exported constant ScanFailureTopic with the value "scan-failure-v1" is added to the common package's topics configuration file. This represents a new topic identifier without changes to existing logic.

Changes

Cohort / File(s) Summary
Topic Constant Addition
pulsar/common/topics.go
Introduces new public constant ScanFailureTopic for scan failure event routing.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A tiny topic hops into place,
ScanFailureTopic joins the race,
With value "scan-failure-v1" so keen,
The simplest change we've ever seen! 🐰✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'feat: add ScanFailureTopic constant' directly and clearly describes the main change—adding a new constant to the codebase.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/scan-failure-topic

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 8, 2026

Summary:

  • License scan: failure
  • Credentials scan: skipped
  • Vulnerabilities scan: skipped
  • Unit test: success
  • Go linting: success

@kooomix kooomix merged commit c5075cd into main Mar 8, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants