Skip to content

add pprof labels for rules #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YakirOren wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add pprof labels for rules #755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eaf003b
add pprof labels for rules
YakirOren Mar 25, 2026
366c663
.
YakirOren Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions pkg/containerwatcher/v2/event_handler_factory.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
package containerwatcher

import (
"context"
"runtime/pprof"

mapset "github.com/deckarep/golang-set/v2"
"github.com/goradd/maps"
containercollection "github.com/inspektor-gadget/inspektor-gadget/pkg/container-collection"
Expand Down Expand Up @@ -194,17 +197,19 @@ func (ehf *EventHandlerFactory) ProcessEvent(enrichedEvent *events.EnrichedEvent
return
}

// Process event through each handler
for _, handler := range handlers {
if enrichedHandler, ok := handler.(containerwatcher.EnrichedEventReceiver); ok {
enrichedHandler.ReportEnrichedEvent(enrichedEvent)
} else if handler, ok := handler.(containerwatcher.EventReceiver); ok {
handler.ReportEvent(eventType, enrichedEvent.Event)
pprof.Do(context.Background(), pprof.Labels("event", string(eventType)), func(_ context.Context) {
// Process event through each handler
for _, handler := range handlers {
if enrichedHandler, ok := handler.(containerwatcher.EnrichedEventReceiver); ok {
enrichedHandler.ReportEnrichedEvent(enrichedEvent)
} else if handler, ok := handler.(containerwatcher.EventReceiver); ok {
handler.ReportEvent(eventType, enrichedEvent.Event)
}
}
}

// Report to third-party event receivers
ehf.reportEventToThirdPartyTracers(enrichedEvent)
// Report to third-party event receivers
ehf.reportEventToThirdPartyTracers(enrichedEvent)
})
}

// registerHandlers registers all handlers for different event types
Expand Down
13 changes: 11 additions & 2 deletions pkg/rulemanager/rule_manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"context"
"crypto/md5"
"fmt"
"runtime/pprof"
"time"

"github.com/armosec/armoapi-go/armotypes"
Expand Down Expand Up @@ -227,7 +228,11 @@ func (rm *RuleManager) ReportEnrichedEvent(enrichedEvent *events.EnrichedEvent)
}

startTime := time.Now()
shouldAlert, err := rm.celEvaluator.EvaluateRule(enrichedEvent, rule.Expressions.RuleExpression)
var shouldAlert bool
var err error
pprof.Do(context.Background(), pprof.Labels("rule", rule.ID), func(_ context.Context) {
shouldAlert, err = rm.celEvaluator.EvaluateRule(enrichedEvent, ruleExpressions)
})
evaluationTime := time.Since(startTime)
rm.metrics.ReportRuleEvaluationTime(rule.Name, eventType, evaluationTime)

Expand Down Expand Up @@ -351,7 +356,11 @@ func (rm *RuleManager) EvaluatePolicyRulesForEvent(eventType utils.EventType, ev
}

startTime := time.Now()
shouldAlert, err := rm.celEvaluator.EvaluateRule(enrichedEvent, ruleExpressions)
var shouldAlert bool
var err error
pprof.Do(context.Background(), pprof.Labels("rule", rule.ID), func(_ context.Context) {
shouldAlert, err = rm.celEvaluator.EvaluateRule(enrichedEvent, ruleExpressions)
})
evaluationTime := time.Since(startTime)
rm.metrics.ReportRuleEvaluationTime(rule.ID, eventType, evaluationTime)

Expand Down
Loading