Skip to content

pass component prerelease image tag to E2E tests#765

Open
bvolovat wants to merge 1 commit intomainfrom
fix/pass-component-image-tags-v2
Open

pass component prerelease image tag to E2E tests#765
bvolovat wants to merge 1 commit intomainfrom
fix/pass-component-image-tags-v2

Conversation

@bvolovat
Copy link
Copy Markdown
Contributor

@bvolovat bvolovat commented Mar 31, 2026

Summary

  • Pass the prerelease image tag via component_image_tags in the E2E dispatch payload (local workflow copy)
  • Same change as kubescape/workflows but for node-agent's local incluster-comp-pr-merged.yaml
  • Removes charts_name from dispatch (receiver defaults it) to stay within GitHub's 10 key limit on client_payload

How it works

The dispatch now includes component_image_tags=nodeAgent-tag=<prerelease-version>. The receiver forwards it to system tests which override the helm chart image tag.

Test plan

  • Merge armosec/shared-workflows companion PR first
  • Trigger a node-agent PR merge and verify E2E tests use the prerelease image

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated CI/CD workflow configuration to refine how component image information is passed to automated testing processes, ensuring improved coordination of built artifacts across deployment pipelines.

Replace the hardcoded charts_name (already defaulted in the receiver)
with component_image_tags so system tests run against the actual
pre-release image instead of the default release.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 31, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f4710e49-96c6-4692-8119-d850fe56843f

📥 Commits

Reviewing files that changed from the base of the PR and between 0627d26 and 6f15eff.

📒 Files selected for processing (1)
  • .github/workflows/incluster-comp-pr-merged.yaml

📝 Walkthrough

Walkthrough

A GitHub Actions workflow was modified to change the dispatch payload sent to a Helm E2E testing job. The charts_name field was removed, and a new component_image_tags field was added using the component name and image tag from the Docker build step.

Changes

Cohort / File(s) Summary
Workflow Dispatch Payload
.github/workflows/incluster-comp-pr-merged.yaml
Removed client_payload[charts_name] field; added client_payload[component_image_tags] constructed from COMPONENT_NAME and IMAGE_TAG_PRERELEASE. The charts_repo field remains unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • Naor-Armo

Poem

🐰 A workflow hops along with glee,
Tags and names passed with such clarity,
Old fields vanish, new ones appear,
Component images tagged without fear! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: passing component prerelease image tags to E2E tests, which matches the core modification of adding component_image_tags to the workflow dispatch payload.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/pass-component-image-tags-v2

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants