Skip to content

feat(R1016): add Signed Profile Tampered rule (metadata-only)#40

Open
matthyx wants to merge 1 commit into
mainfrom
add-r1016-signed-profile-tampered
Open

feat(R1016): add Signed Profile Tampered rule (metadata-only)#40
matthyx wants to merge 1 commit into
mainfrom
add-r1016-signed-profile-tampered

Conversation

@matthyx

@matthyx matthyx commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Adds R1016 "Signed profile tampered" to the rule library as the single source of truth, so it flows into node-agent's bundled default-rules.yaml via the normal rules-crd.yaml sync.

Why metadata-only

R1016 is code-emitted by node-agent's tamper-detection path (pkg/objectcache/containerprofilecache/tamper_alert.go) when a cryptographically signed user-managed ApplicationProfile/NetworkNeighborhood is loaded and its signature is present but no longer valid. It is not triggered by an eBPF event, so — unlike every other rule here — it carries no eventType and an empty ruleExpression. node-agent's engine (rulecreator.CreateRulesByEventType) iterates ruleExpression[].eventType, so an empty list means the rule's metadata is registered but it is never CEL-evaluated (no spurious firing).

Contents

  • pkg/rules/r1016-signed-profile-tampered/signed-profile-tampered.yaml — name, id, description, severity 10 (Critical), MITRE Defense Evasion / Impair Defenses (TA0005 / T1562), tags, isTriggerAlert: true, empty ruleExpression.
  • pkg/rules/r1016-signed-profile-tampered/README.md
  • Regenerated rules-crd.yaml (R1016 inserted between R1015 and R1030; 30 rules total).

Companion to node-agent #808 (signing & tamper detection); node-agent's default-rules.yaml will be synced from this.

🤖 Generated with Claude Code

@matthyx matthyx added the ai-assisted Created through Armosec AI tooling (armosec-shared-rules plugin) label Jun 26, 2026
@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@matthyx, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 27 minutes and 35 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4c3db8e4-6077-4393-a9f4-c6817ebdf798

📥 Commits

Reviewing files that changed from the base of the PR and between e2fe00e and fb46ba0.

📒 Files selected for processing (3)
  • pkg/rules/r1016-signed-profile-tampered/README.md
  • pkg/rules/r1016-signed-profile-tampered/signed-profile-tampered.yaml
  • rules-crd.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch add-r1016-signed-profile-tampered

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

R1016 "Signed profile tampered" is emitted by node-agent's tamper-detection
code path (pkg/objectcache/containerprofilecache/tamper_alert.go) when a
cryptographically signed user-managed ApplicationProfile or NetworkNeighborhood
is loaded and its signature is present but no longer valid.

It is code-emitted, not eBPF/CEL-driven, so the entry carries no eventType and
an empty ruleExpression — the engine registers its metadata (name, severity 10,
MITRE TA0005/T1562, tags) but never CEL-evaluates it. Adding it here keeps
rulelibrary the single source of truth; node-agent's bundled default-rules.yaml
is synced from the regenerated rules-crd.yaml.

Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
@matthyx matthyx force-pushed the add-r1016-signed-profile-tampered branch from 6b184b0 to fb46ba0 Compare June 26, 2026 20:54
@matthyx matthyx moved this to WIP in KS PRs tracking Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-assisted Created through Armosec AI tooling (armosec-shared-rules plugin)

Projects

Status: WIP

Development

Successfully merging this pull request may close these issues.

1 participant