📖 Fix data-at-rest claim in security self-assessment

[clubanderson]

📌 Fixes

---

📝 Summary of Changes

• Fixes misleading Non-Goals bullet that claimed Console does "not store cluster data at rest (except user preferences in local SQLite)"
• Replaces with accurate statement that raw K8s resource data is not stored server-side, with link to new Data Storage Summary
• Adds Data Storage Summary table to the Appendix documenting all 6 persistence layers (backend SQLite, metrics history JSON, OPFS SQLite, IndexedDB, localStorage, in-memory SSE cache)
• Corrects Backend SQLite location from /data/console.db to ./data/console.db (or DATABASE_PATH); Helm default /app/data/console.db
• Corrects Backend SQLite retention from Indefinite to mixed policy (user/config data: until deleted; GPU snapshots: 90 days; revoked JWT tokens: deleted after expires_at)
• Rewords table intro from "details all data persisted" to "provides a high-level summary" to avoid implying exhaustiveness
• Updates "Key points" bullet to explicitly name server-side objects (user accounts, dashboards/cards/configuration, feature requests, GPU utilization snapshots) instead of the misleading "user preferences"

This matters because the self-assessment is referenced in the CNCF TOC sandbox application — accuracy is critical for TAG-Security review.

---

Changes Made

• Corrected misleading Non-Goals bullet about data at rest in docs/security/SELF-ASSESSMENT.md
• Added Data Storage Summary table to the Appendix
• Fixed Backend SQLite location and retention fields to reflect actual defaults and mixed retention policy
• Reworded table intro to clarify it is a high-level summary, not exhaustive
• Updated "Key points" bullet to name server-side stored objects explicitly

---

Checklist

Please ensure the following before submitting your PR:

• I used a coding agent (Claude Code, Copilot, Gemini, or Codex) to generate/review this code
• I have reviewed the project's contribution guidelines
• New cards target console-marketplace, not this repo
• isDemoData is wired correctly (cards show Demo badge when using demo data)
• I have written unit tests for the changes (if applicable)
• I have tested the changes locally and ensured they work as expected
• All commits are signed with DCO (git commit -s)

---

Screenshots or Logs (if applicable)

Documentation-only change — no screenshots applicable.

---

👀 Reviewer Notes

Cross-reference the Data Storage Summary table against:

• pkg/store/sqlite.go — backend SQLite schema and cleanup jobs
• pkg/agent/metrics_history.go — 7-day rolling metrics history
• web/src/lib/cache/ — OPFS/IndexedDB browser cache layer
• deploy/helm/kubestellar-console/values.yaml — Helm DATABASE_PATH default (/app/data/console.db)

[kubestellar-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mikespreitzer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[netlify]

✅ Deploy Preview for kubestellarconsole canceled.

Name	Link
🔨 Latest commit	6ebab63
🔍 Latest deploy log	https://app.netlify.com/projects/kubestellarconsole/deploys/69cef446c38ddc00085a3bcc

[github-actions]

👋 Hey @clubanderson — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

• Claude Code (Opus 4.5 / 4.6) — recommended
• GitHub Copilot
• Cursor
• Other AI coding assistants

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.

---

This is an automated message.

[Copilot]

Pull request overview

Updates the security self-assessment to correct an inaccurate “data at rest” non-goal and to document the console’s actual persistence surfaces more explicitly for TAG-Security review.

Changes:

• Replaces the misleading “does not store cluster data at rest” claim with a more precise statement about not persisting raw K8s resource data server-side.
• Adds a new Data Storage Summary section to the Appendix describing server-side and client-side persistence layers.
• Updates the Table of Contents to include the new Appendix subsection.

[Copilot]

The Backend SQLite location and retention look inaccurate/misleading. The backend default is ./data/console.db (or DATABASE_PATH), and the Helm chart defaults to /app/data/console.db—not /data/console.db. Also, not all data in this DB is indefinite: GPU utilization snapshots are cleaned up after 90 days and revoked tokens are deleted after expires_at passes. Please update the Location/Retention cells to reflect these defaults and mixed retention.

Suggested change

| **Backend SQLite** | Relational DB | User accounts, dashboard layouts, card configurations, GPU utilization snapshots, revoked JWT tokens, user analytics events, feature requests | Server: `/data/console.db` | Indefinite |

| **Backend SQLite** | Relational DB | User accounts, dashboard layouts, card configurations, GPU utilization snapshots, revoked JWT tokens, user analytics events, feature requests | Server default: `./data/console.db` (or `DATABASE_PATH`); Helm default: `/app/data/console.db` | Mixed: user/configuration data retained until deleted; GPU utilization snapshots cleaned up after 90 days; revoked JWT tokens deleted after `expires_at` |

[Copilot]

This section says the table “details all data persisted”, but the Backend SQLite row doesn’t currently cover several server-side tables that are persisted (e.g., onboarding responses, notifications, GPU reservations, PR feedback, pending swaps/card history). Either expand the row to include these categories or reword the intro to clarify the table is a high-level summary rather than exhaustive.

[Copilot]

The “Key points” bullet says the backend SQLite DB stores “user preferences”, but the backend schema is primarily user accounts + dashboards/cards/config, onboarding responses, notifications, etc. To avoid confusion with browser-stored preferences (theme/UI state in localStorage), consider rephrasing this bullet to name the server-side objects explicitly (e.g., users/dashboards/cards/feature requests + GPU snapshot history).

Suggested change

	- The backend SQLite database stores user preferences and dashboard configuration, plus GPU utilization snapshots for historical trend analysis.
	- The backend SQLite database stores server-side application data such as user accounts, dashboards/cards/configuration, feature requests, and GPU utilization snapshots for historical trend analysis.

[clubanderson]

🔄 Auto-Applying Copilot Code Review

Copilot code review found 2 code suggestion(s) and 1 general comment(s).

@copilot Please apply all of the following code review suggestions:

• docs/security/SELF-ASSESSMENT.md (line 157): | **Backend SQLite** | Relational DB | User accounts, dashboard layouts, card co...
• docs/security/SELF-ASSESSMENT.md (line 168): - The backend SQLite database stores server-side application data such as user a...

Also address these general comments:

• docs/security/SELF-ASSESSMENT.md (line 157): This section says the table “details all data persisted”, but the Backend SQLite row doesn’t currently cover several ser

Push all fixes in a single commit. Run cd web && npm run build && npm run lint before committing.

---

Auto-generated by copilot-review-apply workflow.

[kubestellar-prow]

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

• 6ebab63 📖 Fix Backend SQLite location, retention, and key-points bullet per review feedback

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[Copilot]

🔄 Auto-Applying Copilot Code Review

Copilot code review found 2 code suggestion(s) and 1 general comment(s)....

Applied all three changes in commit 6ebab63:

1. Line 157 (Backend SQLite row) — Updated Location to ./data/console.db (or DATABASE_PATH); Helm default /app/data/console.db, and Retention to reflect the mixed policy (user/config data: until deleted; GPU snapshots: 90 days; revoked JWT tokens: deleted after expires_at).
2. Line 153 (table intro) — Rewrded from "details all data persisted" to "provides a high-level summary" to avoid implying the table is exhaustive.
3. Line 168 (Key points bullet) — Replaced "user preferences and dashboard configuration" with explicit server-side object names (user accounts, dashboards/cards/configuration, feature requests, GPU utilization snapshots).

[clubanderson]

Superseded — self-assessment updated directly via cncf/toc#2106 with TAG-Security reviewer feedback addressed. Will sync console copy separately.