test: Add test cases for discovery.go

[gaurab-khanal]

Description

This PR adds test cases for discovery.go.

[gaurab-khanal]

@Rupam-It I got one error here for TestBuildClusterClient.

--- FAIL: TestBuildClusterClient (0.00s)
    --- FAIL: TestBuildClusterClient/exists_kubeconfig_and_context_override_wds1 (0.00s)
        discovery_test.go:200: Expected ctxName to be "wds1", but got "test-context"
        discovery_test.go:203: Expected clusterName to be "wds1-cluster", but got "test-cluster"

It seems like

ctxName := rawCfg.CurrentContext 

doesn't returns override context.

Reference: https://github.com/kubestellar/kubectl-plugin/blob/main/pkg/cluster/discovery.go#L136

Can't we just return overrides.CurrentContext as the ctxName.
Reference: https://github.com/kubestellar/kubectl-plugin/blob/main/pkg/cluster/discovery.go#L102C3-L102C27

[gaurab-khanal]

@Rupam-It Any updates for this?

[Rupam-It]

Hii @gaurab-khanal can you please describe what the problem with ctx?

[gaurab-khanal]

@Rupam-It here I have set the current context as test-context https://github.com/kubestellar/kubectl-plugin/pull/81/files#diff-a293e138a2305a7b5edbee39b5761ae99ca0797166ba219eef41b582bbbe6fbcR49

In this test I have set the context override to wds1 https://github.com/kubestellar/kubectl-plugin/pull/81/files#diff-a293e138a2305a7b5edbee39b5761ae99ca0797166ba219eef41b582bbbe6fbcR172 but got test-context .

This may be due to https://github.com/kubestellar/kubectl-plugin/blob/main/pkg/cluster/discovery.go#L136 not returning the override context.

[Rupam-It]

@gaurab-khanal Now I understand the problem ! Did you think any solution of this problem ?

[gaurab-khanal]

@Rupam-It Instead of returning current context via https://github.com/kubestellar/kubectl-plugin/blob/main/pkg/cluster/discovery.go#L136
can't we just return current context via https://github.com/kubestellar/kubectl-plugin/blob/main/pkg/cluster/discovery.go#L102 ?

[Rupam-It]

I'm not sue about this !
I have to do research about it and if you done any research on this please go ahead!
check that if your proposed solution is working or not!

[rishi-jat]

@gaurab-khanal is the issue you were facing is fixed ?

[gaurab-khanal]

@Rupam-It here current context is returned instead of override context. https://github.com/kubestellar/kubectl-plugin/blob/main/pkg/cluster/discovery.go#L136

In test file, we have current context as test-context but here in this test case I have override the context to wds1 but the function is returning current context which is test-context.
So in this file at 1st check if context override is provided or not. If provided return ctxName as overridecontext else return current context.

[clubanderson]

❌ PR Title Verification Failed

Your PR title does not follow the required format.

Current title: test: Add test cases for discovery.go

Required Format

PR titles must start with one of these emoji prefixes:

Emoji	Meaning
⚠️	Breaking change
✨	Non-breaking feature
🐛	Patch fix / Bug fix
📖	Documentation
🚀	Release
🌱	Infra/Tests/Other

How to Fix

Edit your PR title to start with the appropriate emoji. For example:

• ✨ Add new feature for user authentication
• 🐛 Fix crash when loading empty config
• 📖 Update installation guide

You can edit the title by clicking the Edit button next to your PR title.

---

This comment was posted to help you fix the PR title format.