Fix: Add Validation for Environment Variables in config.py#10
Open
kunalbhardwaj2006 wants to merge 1 commit into
Open
Fix: Add Validation for Environment Variables in config.py#10kunalbhardwaj2006 wants to merge 1 commit into
kunalbhardwaj2006 wants to merge 1 commit into
Conversation
Owner
Author
|
Hi maintainers 👋 I noticed that some environment variables in config.py were being parsed directly using int() and assert, which could lead to unclear errors if invalid values are provided. This PR adds validation and safe parsing helpers to improve configuration robustness and provide clearer error messages. Happy to adjust if there is a preferred configuration pattern in the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves configuration safety by validating environment variables in config.py.
Changes:
These improvements prevent misconfiguration and provide clearer error messages when environment variables contain invalid values.