fix: restore Escape input in WezTerm#16
Merged
Merged
Conversation
The enable_kitty_keyboard option added in PR #15 caused a total-loss regression: physical Escape never registered in Neovim under Herdr after a rebuild. Remove the option and its README explainer so viewers who follow this setup are not broken.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
URGENT ROLLBACK in this public teaching repo. PR #15 added config.enable_kitty_keyboard = true to home/.config/wezterm/wezterm.lua (plus a two-line comment above it) and a README explainer line about the kitty keyboard protocol. That option caused a total-loss regression: physical Escape never registers in Neovim under Herdr after a rebuild. The fix removes BOTH additions from PR #15 and nothing else: (1) the two comment lines and the config.enable_kitty_keyboard option in wezterm.lua, cleaning up the orphaned blank line so there is a single blank line before 'return config'; (2) the single README explainer sentence on the 'About herdr' paragraph. This is a pure revert with footprint of exactly those two removals - no other behavior, docs, or files change. Because it is a public teaching repo, the goal is that a viewer who copies this config simply no longer has the broken option.
What Changed
Risk Assessment
✅ Low: The change is a tightly scoped rollback that exactly restores the repository tree to the state before PR #15, with no unrelated changes or residual documentation inconsistencies.
Testing
Verified the five-line, two-file rollback footprint, loaded the copied configuration successfully with WezTerm, confirmed all broken-option text is absent, and proved the target tree exactly matches the pre-PR #15 tree; the transcript captures the end-user configuration and documentation surfaces, and no screenshot was applicable because this is a configuration rollback with no rendered UI change.
Evidence: Rollback end-to-end transcript
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
git diff --no-ext-diff --unified=20 95cf01b042f23513cc86afbaa64c7d306b00467f..b1a739474cec41b11d20a719cc360d6afc76cef8git diff --check 95cf01b042f23513cc86afbaa64c7d306b00467f..b1a739474cec41b11d20a719cc360d6afc76cef8wezterm --config-file home/.config/wezterm/wezterm.lua show-keys --key-table defaultrg -n "enable_kitty_keyboard|kitty keyboard protocol|atomic key event|tailgating mouse" README.md homegit diff --quiet 95cf01b^ b1a7394Manually inspected the final WezTerm config tail and READMEherdrparagraph in the evidence transcript.✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.