feat: balance dispatch by quota run rate#721
Open
alimohammad-123 wants to merge 19 commits into
Open
Conversation
…g process arguments
…g process arguments
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
quotaBalancedtuning for reserves, reset capacity, stale-data margins, and private lock-safe usage history, with account-free diagnostics and safe fallback behavior.Risk Assessment
✅ Low: Captain, the prior blocking defect is correctly fixed by excluding quota-axi's code-review window IDs, and the updated selector remains bounded by conservative fallback behavior.
Testing
Completed 1 recorded test check.
Pipeline
Updates from git push no-mistakes
⏭️ **intent** - skipped
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
🔧 **Review** - 1 issue found → auto-fixed ✅
bin/fm-dispatch-select.sh:379- Exclude feature-scoped Codex windows from general quota scoring. quota-axi emitscode_review_five_hourandcode_review_weeklywith kindssessionandweekly, so this filter includes them and can make low code-review quota incorrectly disqualify Codex even when its general quota is healthy. Restrict Codex general windows to the base window IDs, or explicitly rejectcode_review_*, and cover that schema case.🔧 Fix: Exclude code-review windows from general quota scoring
✅ Re-checked - no issues remain.
🔧 **Test** - 1 issue found → auto-fixed (3) ✅
command -v tmux >/dev/null || { echo "tmux is required for e2e tests" >&2; exit 1; }; tmux -V; rc=0; for t in tests/*.test.sh; do echo "== $t =="; bash "$t" || rc=1; done; exit "$rc"🔧 Fix: Captain: stabilize secondmate seed rollback cleanup
1 error still open:
command -v tmux >/dev/null || { echo "tmux is required for e2e tests" >&2; exit 1; }; tmux -V; rc=0; for t in tests/*.test.sh; do echo "== $t =="; bash "$t" || rc=1; done; exit "$rc"🔧 Fix: Stabilize watcher stale-absorb test synchronization
1 error still open:
command -v tmux >/dev/null || { echo "tmux is required for e2e tests" >&2; exit 1; }; tmux -V; rc=0; for t in tests/*.test.sh; do echo "== $t =="; bash "$t" || rc=1; done; exit "$rc"🔧 Fix: Captain: stabilize bootstrap timeout fixture synchronization
✅ Re-checked - no issues remain.
command -v tmux >/dev/null || { echo "tmux is required for e2e tests" >&2; exit 1; }; tmux -V; rc=0; for t in tests/*.test.sh; do echo "== $t =="; bash "$t" || rc=1; done; exit "$rc"✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.