Feat/custom commit message conventions#95
Open
calvinnwq wants to merge 3 commits intokunchenguid:mainfrom
Open
Feat/custom commit message conventions#95calvinnwq wants to merge 3 commits intokunchenguid:mainfrom
calvinnwq wants to merge 3 commits intokunchenguid:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
commitMessage.preset: angularconfig support so successful iteration commits can use agent-provided Angular-style commit metadata.Risk Assessment
✅ Low: The branch adds a narrowly scoped optional commit-message preset with schema, prompt, config, and commit-message plumbing, and I did not find material correctness, security, performance, or error-handling issues in the changed code.
Testing
npx vitest run src/core/commit-message.test.ts src/core/config.test.ts src/core/agents/types.test.ts src/core/agents/factory.test.ts src/core/run.test.ts src/templates/iteration-prompt.test.ts src/core/orchestrator.test.ts src/cli.test.tsnpm testPipeline
Updates from git push no-mistakes
✅ **Rebase** - passed
Round 1 - passed ✅
✅ **Review** - passed
Round 1 - passed ✅
✅ **Test** - passed
Round 1 - passed ✅
npx vitest run src/core/commit-message.test.ts src/core/config.test.ts src/core/agents/types.test.ts src/core/agents/factory.test.ts src/core/run.test.ts src/templates/iteration-prompt.test.ts src/core/orchestrator.test.ts src/cli.test.tsnpm test🔧 **Document** - 3 issues found → auto-fixed
Round 1 - found 3 issues (1 warning, 2 infos)
README.md:229- The newcommitMessageuser configuration is documented, but the README does not document the Angular preset's concrete output contract: validtypevalues arebuild,ci,docs,feat,fix,perf,refactor,test, andchore; omitted or invalid types fall back tochore; and an empty scope is omitted from the header. This is user-visible behavior enforced by the schema and commit-message renderer.AGENTS.md:39- The agent architecture docs still describeAgentOutputas onlysuccess,summary,key_changes_made,key_learnings, plus optionalshould_fully_stop. WithcommitMessage.preset: angular, the schema now also requires commit-message fields such astypeandscope, andAgentOutputpermits these dynamic fields. Update this section so future agent/schema changes do not rely on stale documentation.AGENTS.md:49- The config architecture docs listagentPathOverrideandagentArgsOverridebut omit the new optionalcommitMessageconfig. Update this section to mention thatcommitMessage.preset: angularchanges the generated output schema/prompt and the successful-iteration commit subject.Round 2 (auto-fix) - passed ✅
🔧 **Lint** - 1 issue found → auto-fixed
Round 1 - found 1 warning
test/e2e.test.ts:133- Prettier reported code style issues in this changed file. The required formatting starts at line 133, including wrapping long function calls and object literals.Round 2 (auto-fix) - passed ✅
✅ **Push** - passed
Round 1 - passed ✅