Merged
Conversation
w1am
approved these changes
Aug 12, 2025
w1am
left a comment
There was a problem hiding this comment.
Probably should fix the the ci to use docker compose v2 syntax
mackrorysd
approved these changes
Aug 12, 2025
mackrorysd
left a comment
There was a problem hiding this comment.
No objection - CI was previously failing so we should see to that at some point. I feel like I'm missing a little context because I'm not sure why a version bump would require multiple reviewers, nor do I have any special knowledge here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the cloud tutorial to use the KurrentDB python client, aligning the connection URL format to what is displayed by Kurrent Cloud. Also updating Shadowtraffic version and JRE