make some socket and buffer settings configurable.#7
Merged
Conversation
hack: use raw sockets, set config like gRPC make socket and buffer paramaters a bit more configurable
PDXKimani
changed the title
kvc0
reviewed
Sep 16, 2025
| #[derive(Debug, Clone)] | ||
| pub struct ClientRegistry<TConnector = TcpConnector> { | ||
| max_buffer_length: usize, | ||
| buffer_allocation_interval: usize, |
Owner
There was a problem hiding this comment.
You used "increment" in the Connection and SocketServer. I think that's the better word, and it should be consistent here and elsewhere.
Contributor
Author
There was a problem hiding this comment.
too many simultaneous conversations frazzled the brain. Yes, that's what I intended to use.
Owner
There was a problem hiding this comment.
no worries, I was pretty sure it was just a mistype anyway
kvc0
approved these changes
Sep 16, 2025
Owner
|
@PDXKimani you missed cargo fmt; I'd do it myself but I'm afk... push the fmt fix and I'll merge |
Contributor
Author
@kvc0 fixed, thanks |
Owner
|
Thanks for the change! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.