Fix GetCodedName vtable indices for GdCliGadget & ChCliCharacter

[anonre]

I find it good that you make your project open-source, so I want to help you with the coded names. I am sure you prob were already working on it /shrug. If you need any other offsets just lmk. I have most useful classes reversed for my private cheat.

Code is a little bit ugly, just wanted to make a quick PoC.

To find the functions just search for L"codedName" in your disassembler.

if ( v8 ) {
  v9 = v8 - 0xA;
  if ( v9 ) {
    if ( v9 == 1 ) {
      v10 = v69;
      v11 = *(void (__fastcall **)(__int64, const wchar_t *, __int64))(*(_QWORD *)v69 + 0x80LL);
      v12 = sub_1409C1900((__int64)v57, (__int64)L"attack_target");
      v11(v10, L"type", v12);
      v13 = sub_141335CC0(i);
      v14 = v69;
      v15 = (*(__int64 (__fastcall **)(__int64))(*(_QWORD *)v13 + 0x10LL))(v13);
      v16 = (*(__int64 (__fastcall **)(__int64))(*(_QWORD *)v15 + 0x40LL))(v15);// getCodedName
      v17 = *(void (__fastcall **)(__int64, const wchar_t *, __int64))(*(_QWORD *)v14 + 0x80LL);
      v18 = sub_1409C1900((__int64)v58, v16);
      v17(v14, L"codedName", v18);
    }
  } else {
    v19 = v69;
    v20 = *(void (__fastcall **)(__int64, const wchar_t *, __int64))(*(_QWORD *)v69 + 0x80LL);
    v21 = sub_1409C1900((__int64)v59, (__int64)L"gadget");
    v20(v19, L"type", v21);
    pGdCliGadget = sub_1413321B0(i);
    v23 = v69;
    v24 = (*(__int64 (__fastcall **)(__int64))(*(_QWORD *)pGdCliGadget + 0x40LL))(pGdCliGadget);// getCodedName vtbl[8]
    v25 = *(void (__fastcall **)(__int64, const wchar_t *, __int64))(*(_QWORD *)v23 + 0x80LL);
    v26 = sub_1409C1900((__int64)v60, v24);
    v25(v23, L"codedName", v26);
  }
} else {
  v27 = v69;
  v28 = *(void (__fastcall **)(__int64, const wchar_t *, __int64))(*(_QWORD *)v69 + 0x80LL);
  v29 = sub_1409C1900((__int64)v61, (__int64)L"character");
  v28(v27, L"type", v29);
  pChCliCharacter = sub_1411A9FE0(i);
  v31 = v69;
  v32 = (_QWORD *)pChCliCharacter;
  v33 = (*(__int64 (__fastcall **)(__int64))(*(_QWORD *)pChCliCharacter + 0x1C8LL))(pChCliCharacter);// getCodedName vtbl[57]
  v34 = *(void (__fastcall **)(__int64, const wchar_t *, __int64))(*(_QWORD *)v31 + 0x80LL);
  v35 = sub_1409C1900((__int64)v62, v33);
  v34(v31, L"codedName", v35);
  // ...
}

[Krixx1337]

Thanks for the contribution, I really appreciate it! I'll review it soon.

I already have a name resolver for NPC names, gadget names, and gadget interaction prompts, but I kept it private since the code got quite complex.

Add me on Discord (krixx1337) so we can discuss it and decide whose implementation we should include

[anonre]

Thanks for the contribution, I really appreciate it! I'll review it soon.

I already have a name resolver for NPC names, gadget names, and gadget interaction prompts, but I kept it private since the code got quite complex.

Add me on Discord (krixx1337) so we can discuss it and decide whose implementation we should include

i am xuxuxu. (Joln)