Surface unhandled exceptions in CLI and TestHarness#62
Open
kyurkchyan wants to merge 1 commit into
Open
Conversation
The outer catch in CommandExecutionService silently swallowed any exception not handled by BaseCommandHandler's specific catches (auth, ServiceBus, cancellation), so failures like missing queues or unexpected errors exited with code 1 and no output. Print the exception to stderr in the safety net, and add a generic catch in BaseCommandHandler so handler errors get formatted via IConsoleOutput with stack traces under --verbose. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThis PR enhances error handling in CLI and TestHarness components by capturing exceptions and emitting detailed diagnostic information to standard error, including exception type, message, and stack traces with colored console output, while maintaining existing control flow and exit code behavior. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
SummarySummary
CoverageServiceBusToolset.Application - 64.4%
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
catch (Exception)in bothCommandExecutionServicefiles (CLI and TestHarness) silently swallowed exceptions, setting exit code 1 with no output. Commands likegenerate-dlqfailed without any visible error.BaseCommandHandleronly caughtAuthenticationFailedException,ServiceBusException, andOperationCanceledException— anything else (e.g.MessagingEntityNotFoundException, NREs, argument exceptions) bubbled up to the silent outer catch.Fix
CommandExecutionService(both projects) now printsex.GetType().Name,ex.Message, and fullex.ToString()to stderr in red before setting exit code 1.BaseCommandHandler(both projects) gained a genericcatch (Exception)so expected handler errors get formatted viaIConsoleOutput.Error, with the full stack trace shown when--verboseis passed.BaseCommandHandlerproduces clean user-facing messages;CommandExecutionServiceis the safety net for failures outside a handler (DI resolution, parser, etc.).Test plan
dotnet run --project src/ServiceBusToolset.TestHarness -- generate-dlq -n <bad-namespace> -q <bad-queue> -c 1and confirm the auth/ServiceBus error is now visible.🤖 Generated with Claude Code
Summary by CodeRabbit