assumevalid checks#170
Draft
l0rinc wants to merge 4 commits into
Draft
Conversation
The assumevalid decision now gates more than script verification. Rename the local reason pointer and the cached logged reason before changing behavior so the follow-up commits can stay focused.
The assumevalid gate already decides when old blocks on the assumed-valid chain can skip script checks. Use that same decision to skip BIP30 overwrite checks while connecting those blocks. Extend `feature_assumevalid.py` with a duplicate coinbase so the skipped and enforced BIP30 paths are covered.
Assumevalid skips script checks for buried blocks on the assumed-valid chain. Skip contextual block sigops counting under the same gate, while leaving the context-free legacy sigops check in `CheckBlock()` unchanged. Extend `feature_assumevalid.py` with P2SH sigops so the assumed-valid block exercises `ConnectBlock()` sigops counting and the post-assumevalid child proves sigops are enforced again.
The assumevalid gate now covers more than script verification. Update the help text, logs, comments, and functional-test expectations to describe script, BIP30, and sigops checks together.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.