Allow a variable number of instructions per pseudoclock#35
Open
philipstarkey wants to merge 4 commits intolabscript-suite:masterfrom
Open
Allow a variable number of instructions per pseudoclock#35philipstarkey wants to merge 4 commits intolabscript-suite:masterfrom
philipstarkey wants to merge 4 commits intolabscript-suite:masterfrom
Conversation
…pseudoclock. There is a bug in the default allocation algorithm that prevents increasing the number of pseudoclocks. This needs fixing later!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
This isn't well tested!
Fixes #31
This introduces a new command
setnuminstructions <pseudoclock:int> <num_instructions:int>that allows you to reallocate instructions storage from one pseudoclock to another.For example, you could split your pseudoclock instructions such that only a small number (<100) were used for a Novatech DDS9m clock (assuming that most of the Novatech instructions were used in a couple of labscript ramps), with the remaining 14,900 were reallocated to another pseudoclock.