Add logic tree for conditional voltage setting based on freq request#37
Open
Json-To-String wants to merge 2 commits intolabscript-suite:overclockfrom
Open
Add logic tree for conditional voltage setting based on freq request#37Json-To-String wants to merge 2 commits intolabscript-suite:overclockfrom
Json-To-String wants to merge 2 commits intolabscript-suite:overclockfrom
Conversation
dihm
reviewed
Aug 27, 2025
Collaborator
dihm
left a comment
dihm
left a comment
There was a problem hiding this comment.
Minor comments, otherwise this looks pretty good. Let's get it tested thoroughly before merging, however.
| else | ||
| { | ||
| if (freq >= 150 * MHZ) | ||
| if (freq > overclock_freq_limit * MHZ) |
Collaborator
There was a problem hiding this comment.
I have a small concern about this logic tree. If we go from an overclock state to a normal state, the Vreg will be set down before the frequency change, potentially leading to instability.
We should test that hypothesis thoroughly to see if it is a problem before actually changing code though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR to add the overclock logic detailed here:
#34 (comment)
This will also warn the user in
setclockif they request a frequency that's considered overclocking (currently >200 MHz). I tested with both rp2040 and rp2350 prawnblasters.