Virtual Devices BLACS Plugin#105
Open
carterturn wants to merge 18 commits intolabscript-suite:masterfrom
Open
Conversation
carterturn
force-pushed
the
cartertu-virtual-device-2
branch
from
5191664 to
03ed80f
Compare
Author
|
This has been in testing in our lab for a couple months now, so I am confident it will not break typical setups. |
carterturn
force-pushed
the
cartertu-virtual-device-2
branch
from
14f033a to
790bd1e
Compare
carterturn
changed the title
Digital controls tested. Still need to add mechanism for creating virtual devices. Inverted digital outputs probably do not work.
1. Make sure DO inverted data is reloaded from save 2. Check if BLACS tabs are still available when loading editor
carterturn
force-pushed
the
cartertu-virtual-device-2
branch
from
711f53c to
a0a5de2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is one approach to "Virtual Devices" for BLACS. By "Virtual Devices," I mean a collection of digital, analog, and DDS outputs from a few different hardware devices in a single BLACS tab (a typical example being a "MOT" tab).
A sample image of this plugin in our setup.
There is a suggestion that such functionality partially exists in #25 of labscript; I think this version is a reasonable use of existing APIs and capabilities.
There are a couple of "bug" fixes involved, mostly pertaining to the way inverted digital outputs are handled. These seem to only manifest when additional tab outputs are linked to digital outputs, so they are not an issue except in the context of this plugin. One of these is in labscript-utils, handled by PR labscript-suite/labscript#109.
There are still a few things to fix, but it has reached the point where it reliably works for digital and analog outputs, so I would like to begin soliciting feedback.