Open
Conversation
Added themes in plugins, added scaffolding for other users to add themes as well. Click buttons currently don't follow theme.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first attempt at implementing labscript-suite/labscript-suite#98 and introduces minimal changes to add some out-of-the-box themes to Blacs. I have some ideas of how to better integrate this approach into labscript as a whole (e.g. moving the themes into a common package so that all components can share them) but I wanted to put the PR up to get some eyes on it and so people could test the feature.
To select a new theme, this PR adds a button in the "File"->"Preferences"->"GUI Theme" field, where you can select from the supported themes or even add your own:
I've currently run this on a few different computers, and it is pretty trivial to add new themes, which live in
labscript-suite/blacs/blacs/plugins/theme/themes/*.qss. You can make your own by copying any one of these files and changing the hex values, which VS Code has a nice menu for:In the works is a way to specify a wavelength that goggles will block, and for the theme to intelligently populate colors that are easier to see.