Open
Conversation
Collaborator
rafaelpaniago1
commented
Mar 22, 2026
rafaelpaniago1
commented
- Added first working version of canonicalizer.
- Added test cases to assert correcteness and effectiveness in multiple verilog files.
Adding LSP file
- Basic functions - Function to find reverse topological ordering (Later used in flattening)
Flattening should use straight topological ordering instead of reverse.
- Implemente function that uses topological order to flatten nodes - Fixed small bug in topological order function
- Changed flattening function to not flatten variables that have cyclic dependencies with others in the data flow graph. Future implementation will identify strongly connected components to allow "semi flattening" of such variables.
Fixing bug that corrupted the data integrity of the current state of the data flow graph inside the processing of elements from the topological ordering.
1 - Slice extraction was performed with and without canonicalization 2 - Flattening seems to work properly in all files tested so far 3 - Some of the files were canonicalized by the CIRCT frontend, the flattening function didn't seem to alter those 4 - Only files with meaningful changes were kept 5 - Flattening seems to be more useful for cascading then for expression combination, CIRCT frontend performs those already.
Top ordering function failed to identify cyclic combinational logic in a specific edge case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.