Draft
Conversation
janedotx
reviewed
May 3, 2021
|
|
||
| ## Trips | ||
|
|
||
| The `/trips` endpoint is a subset of the similar endpoint in Provider, except it's push instead of pull. It receives trip information that is above and beyond what is encoded in the register, event and telemetry streams. |
There was a problem hiding this comment.
Why is it only a subset? Might be good to include in the spec.
There was a problem hiding this comment.
I think that's what the second sentence is saying, but maybe there needs to be more language to elaborate upon it. Provider doesn't have a notion of non-event telemetry (closest thing is route in the Provider /trips endpoint), and it also doesn't have an always-present vehicle registry that can be polled (the Provider /vehicles endpoint only returns vehicles in the PROW), so there are some additional pieces of info that need to be in the Provider /trips endpoint that are unnecessary to send to Agency because Agency already has them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft, please review.