fix(data): Ensure that __slots__ is used up the inheritance tree#657
Merged
Conversation
chriswmackey
force-pushed
the
master
branch
3 times, most recently
from
d131af5 to
1060bd1
Compare
I must have forgotten to do this because I didn't fully understand how __slots__ worked when I first started working on this library. This may be responsible for the weirdness here: ladybug-tools#656 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I must have forgotten to do this because I didn't fully understand how slots worked when I first started working on this library.
This may be responsible for the weirdness here:
#656 (comment)