This repository was archived by the owner on Feb 17, 2022. It is now read-only.
Adding more info to IcapException to debug Icap Server disconnection …#9
Open
rahulg11 wants to merge 3 commits into
Open
Adding more info to IcapException to debug Icap Server disconnection …#9rahulg11 wants to merge 3 commits into
rahulg11 wants to merge 3 commits into
Conversation
Contributor
|
+1 looks good |
krdev
reviewed
Mar 22, 2017
krdev
left a comment
krdev
left a comment
Contributor
There was a problem hiding this comment.
Check if the type is InetSocketAddress, if yes, get the port and use that in the Exception.
Also reduce the debug string:
"Channel disconnected, state: XX, port: YY"
added 2 commits
March 31, 2017 22:52
…issue Not adding socket address as it doesnot add any value for debugging.
…lient into SymantecDebugging Conflicts: src/main/java/com/lafaspot/icap/client/session/IcapSession.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symantec Server is disconnecting the session abruptly. Logging more info the exception.