Remove customer identifiers from comments, tests, and CHANGELOG#113
Conversation
There was a problem hiding this comment.
Code Review
This pull request generalizes comments, documentation, and unit tests by replacing specific references to "juultest" with generic terms like "boxes with a different login user" or "benchtest". A minor formatting issue was introduced in cli/commands/utility/install.py where a comment line was accidentally merged with the previous line, which should be split back into two lines to restore readability.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| # Idempotent: re-running install overwrites the file with the same | ||
| # content. Failure here is a warning, not fatal — the box is otherwise | ||
| # installed; the operator can apply the rule manually later. | ||
| # content. Failure here is a warning, not fatal — the box is otherwise # installed; the operator can apply the rule manually later. |
There was a problem hiding this comment.
The comment line was accidentally joined with the next line, resulting in a nested comment marker (#) and poor formatting. Please split it back into two lines for readability.
| # content. Failure here is a warning, not fatal — the box is otherwise # installed; the operator can apply the rule manually later. | |
| # content. Failure here is a warning, not fatal — the box is otherwise | |
| # installed; the operator can apply the rule manually later. |
Replaces customer-derived names in code comments, test fixtures, and one CHANGELOG entry with the technical condition they actually describe. This is a public repo; these names should never have been in it.
cli/commands/box/dut.py,cli/commands/box/_host_ops.py,cli/commands/utility/install.py,cli/commands/utility/update.py: the example box user is now described as "a box whose login user is notlagerdata", which is the condition the reader actually needs.CHANGELOG.md: same substitution in the box-config sudoers entry.test/unit/box/test_host_ops.py,test/unit/box/test_box_dut_cli.py: fixture usernames replaced with neutral ones. The replacements preserve the character classes each fixture exercises (the valid-username list still covers a hyphen+digit name; the invalid-username list still covers an embedded space). One test renamed to drop a customer reference in its name.No behavior change: every hit was a comment or a fixture string, and no assertion logic depends on the values.
Verification
test_box_authorize,test_lock_state,test_monitor_state) are pre-existing and in files this PR does not touch.