Skip to content

Allow dealerdirect/phpcodesniffer-composer-installer plugin#33

Closed
javabudd wants to merge 4 commits into
laminas-api-tools:2.5.xfrom
javabudd:ISSUE-32
Closed

Allow dealerdirect/phpcodesniffer-composer-installer plugin#33
javabudd wants to merge 4 commits into
laminas-api-tools:2.5.xfrom
javabudd:ISSUE-32

Conversation

@javabudd

@javabudd javabudd commented Nov 1, 2022 •
edited
Loading

Copy link
Copy Markdown

Addresses #32

Signed-off-by: andyo andy@servicecore.com

Q A
Documentation no
Bugfix yes
BC Break no
New Feature no
RFC no
QA no

Description

  • Are you fixing a bug?
    • How do you reproduce it? Trigger a build into 2.5.x
    • What was the previous behavior? Builds were passing
    • What is the current behavior? Builds are failing

Allow dealerdirect/phpcodesniffer-composer-installer plugin
f7d5830 
Signed-off-by: andyo <andy@servicecore.com>
@Ocramius Ocramius added this to the 2.5.0 milestone Nov 1, 2022
Update phpunit
c2af1bf 
Signed-off-by: andyo <andy@servicecore.com>
@javabudd

javabudd commented Nov 1, 2022 •
edited
Loading

Copy link
Copy Markdown
Author

Updated PHPUnit to fix a build error with XSD failing on lowest configuration:

Running before_script: xmllint --schema vendor/phpunit/phpunit/phpunit.xsd phpunit.xml.dist
warning: failed to load external entity "vendor/phpunit/phpunit/phpunit.xsd"

https://github.com/laminas-api-tools/api-tools-doctrine/actions/runs/3371630638/jobs/5594294444

Set minimum phpunit version to 9.5.26
d9692e8 
Signed-off-by: andyo <andy@servicecore.com>
@javabudd

javabudd commented Nov 1, 2022 •
edited
Loading

Copy link
Copy Markdown
Author

Updated phpunit to ^9.5.26, apparently the lowest version (somewhere around 9.2) is missing the phpunit.xsd spec. This change lines up with laminas/laminas-servicemanager (https://github.com/laminas/laminas-servicemanager/blob/3.20.x/composer.json#L47)

@javabudd

javabudd commented Nov 1, 2022

Copy link
Copy Markdown
Author

I'm going to revert changes to the lockfile and redo the update, apparently all deps were updated

Update lockfile to reflect phpunit 9.5.26
13ae248 
Signed-off-by: andyo <andy@servicecore.com>
@javabudd

javabudd commented Nov 1, 2022

Copy link
Copy Markdown
Author

Ran the following command to update:

composer update phpunit/phpunit phar-io/manifest phpunit/php-code-coverage sebastian/comparator sebastian/exporter sebastian/type nikic/php-parser --ignore-platform-req=ext-mongodb
Creating api-tools-doctrine_php_run ... done
Loading composer repositories with package information
Info from https://repo.packagist.org: #StandWithUkraine
Updating dependencies
Lock file operations: 0 installs, 7 updates, 0 removals
  - Upgrading nikic/php-parser (v4.10.5 => v4.15.1)
  - Upgrading phar-io/manifest (2.0.1 => 2.0.3)
  - Upgrading phpunit/php-code-coverage (9.2.6 => 9.2.18)
  - Upgrading phpunit/phpunit (9.5.6 => 9.5.26)
  - Upgrading sebastian/comparator (4.0.6 => 4.0.8)
  - Upgrading sebastian/exporter (4.0.3 => 4.0.5)
  - Upgrading sebastian/type (2.3.4 => 3.2.0)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 16 installs, 105 updates, 2 removals
  - Downloading composer/package-versions-deprecated (1.11.99.2)
  - Downloading dealerdirect/phpcodesniffer-composer-installer (v0.7.1)
  - Downloading symfony/polyfill-php80 (v1.23.0)
  - Downloading jean85/pretty-package-versions (1.6.0)
  - Downloading mongodb/mongodb (1.8.0)
  - Downloading alcaeus/mongo-php-adapter (1.2.0)
  - Downloading nikic/php-parser (v4.15.1)
  - Downloading brick/varexporter (0.3.5)
  - Downloading doctrine/deprecations (v0.5.3)
  - Downloading laminas/laminas-zendframework-bridge (1.2.0)
  - Downloading laminas/laminas-stdlib (3.3.1)
  - Downloading psr/container (1.1.1)
  - Downloading container-interop/container-interop (1.2.0)
  - Downloading laminas/laminas-servicemanager (3.6.4)
  - Downloading laminas/laminas-loader (2.7.0)
  - Downloading laminas/laminas-json (3.2.0)
  - Downloading laminas/laminas-eventmanager (3.3.1)
  - Downloading laminas/laminas-view (2.12.0)
  - Downloading laminas/laminas-validator (2.14.4)
  - Downloading laminas/laminas-escaper (2.7.0)
  - Downloading laminas/laminas-uri (2.8.1)
  - Downloading laminas/laminas-http (2.14.3)
  - Downloading laminas/laminas-router (3.4.5)
  - Downloading webimpress/safe-writer (2.2.0)
  - Downloading laminas/laminas-config (3.5.0)
  - Downloading laminas/laminas-modulemanager (2.10.2)
  - Downloading laminas/laminas-mvc (3.2.0)
  - Downloading symfony/polyfill-mbstring (v1.23.0)
  - Downloading symfony/polyfill-intl-normalizer (v1.23.0)
  - Downloading symfony/polyfill-intl-grapheme (v1.23.0)
  - Downloading symfony/polyfill-ctype (v1.23.0)
  - Downloading symfony/string (v5.3.2)
  - Downloading symfony/service-contracts (v2.4.0)
  - Downloading symfony/polyfill-php73 (v1.23.0)
  - Downloading symfony/deprecation-contracts (v2.4.0)
  - Downloading symfony/console (v5.3.2)
  - Downloading psr/cache (1.0.1)
  - Downloading doctrine/lexer (1.2.1)
  - Downloading doctrine/annotations (1.13.1)
  - Downloading doctrine/reflection (1.2.2)
  - Downloading doctrine/event-manager (1.1.1)
  - Downloading doctrine/collections (1.6.7)
  - Downloading doctrine/cache (1.11.3)
  - Downloading doctrine/persistence (1.3.8)
  - Downloading doctrine/inflector (1.4.4)
  - Downloading doctrine/common (2.13.3)
  - Downloading doctrine/mongodb (1.6.4)
  - Downloading doctrine/instantiator (1.4.0)
  - Downloading doctrine/mongodb-odm (1.3.7)
  - Downloading laminas/laminas-paginator (2.10.0)
  - Downloading laminas/laminas-filter (2.11.1)
  - Downloading laminas/laminas-inputfilter (2.12.0)
  - Downloading laminas/laminas-form (2.15.1)
  - Downloading psr/simple-cache (1.0.1)
  - Downloading zendframework/zend-cache (2.9.0)
  - Downloading laminas/laminas-authentication (2.8.0)
  - Downloading doctrine/doctrine-module (2.1.10)
  - Downloading doctrine/doctrine-mongo-odm-module (1.1.1)
  - Downloading doctrine/dbal (2.13.2)
  - Downloading doctrine/orm (2.7.5)
  - Downloading doctrine/doctrine-orm-module (2.1.7)
  - Downloading laminas/laminas-code (4.4.0)
  - Downloading laminas-api-tools/api-tools-versioning (1.4.0)
  - Downloading laminas-api-tools/api-tools-api-problem (1.4.0)
  - Downloading laminas-api-tools/api-tools-content-negotiation (1.5.0)
  - Downloading laminas-api-tools/api-tools-rpc (1.5.0)
  - Downloading laminas/laminas-permissions-rbac (3.1.0)
  - Downloading laminas/laminas-permissions-acl (2.8.0)
  - Downloading webmozart/assert (1.10.0)
  - Downloading laminas/laminas-i18n (2.11.1)
  - Downloading laminas/laminas-mvc-i18n (1.2.0)
  - Downloading laminas/laminas-math (3.3.2)
  - Downloading laminas/laminas-crypt (3.4.0)
  - Downloading bshaffer/oauth2-server-php (v1.11.1)
  - Downloading laminas-api-tools/api-tools-oauth2 (1.7.2)
  - Downloading laminas-api-tools/api-tools-mvc-auth (1.6.0)
  - Downloading laminas-api-tools/api-tools-rest (1.6.1)
  - Downloading laminas-api-tools/api-tools-provider (1.4.0)
  - Downloading laminas-api-tools/api-tools-content-validation (1.9.0)
  - Downloading laminas-api-tools/api-tools-configuration (1.4.1)
  - Downloading laminas-api-tools/api-tools-admin-ui (1.4.0)
  - Downloading laminas/laminas-db (2.12.0)
  - Downloading laminas-api-tools/api-tools (1.5.0)
  - Downloading laminas-api-tools/api-tools-admin (1.9.0)
  - Downloading webimpress/coding-standard (1.2.2)
  - Downloading phpstan/phpdoc-parser (0.5.4)
  - Downloading slevomat/coding-standard (7.0.9)
  - Downloading psr/log (1.1.4)
  - Downloading laminas/laminas-log (2.13.1)
  - Downloading laminas/laminas-serializer (2.10.1)
  - Downloading sebastian/recursion-context (4.0.4)
  - Downloading sebastian/object-reflector (2.0.4)
  - Downloading sebastian/object-enumerator (4.0.4)
  - Downloading sebastian/global-state (5.0.3)
  - Downloading sebastian/diff (4.0.4)
  - Downloading sebastian/code-unit (1.0.8)
  - Downloading phpunit/php-timer (5.0.3)
  - Downloading phpunit/php-text-template (2.0.4)
  - Downloading sebastian/complexity (2.0.2)
  - Downloading sebastian/code-unit-reverse-lookup (2.0.3)
  - Downloading phpunit/php-code-coverage (9.2.18)
  - Downloading phar-io/version (3.1.0)
  - Downloading myclabs/deep-copy (1.10.2)
  - Downloading laminas/laminas-dom (2.8.0)
  - Downloading laminas/laminas-console (2.8.0)
  - Downloading laminas/laminas-test (3.5.1)
  - Downloading phpdocumentor/reflection-common (2.2.0)
  - Downloading phpdocumentor/type-resolver (1.4.0)
  - Downloading phpdocumentor/reflection-docblock (5.2.2)
  - Downloading phpro/zf-doctrine-hydration-module (v4.1.0)
  - Downloading phpspec/prophecy (1.13.0)
  - Downloading phpspec/prophecy-phpunit (v2.0.1)
  - Downloading netresearch/jsonmapper (v4.0.0)
  - Downloading felixfbecker/language-server-protocol (1.5.1)
  - Downloading felixfbecker/advanced-json-rpc (v3.2.1)
  - Downloading composer/xdebug-handler (2.0.1)
  - Downloading composer/semver (3.2.5)
  - Downloading amphp/amp (v2.5.2)
  - Downloading amphp/byte-stream (v1.8.1)
  - Downloading vimeo/psalm (4.8.1)
  - Downloading symfony/yaml (v5.3.2)
  - Removing symfony/debug (v2.8.0)
  - Removing api-skeletons/zf-doctrine-module-zend-hydrator (1.0.0)
  - Upgrading composer/package-versions-deprecated (1.10.99 => 1.11.99.2): Extracting archive
  - Upgrading dealerdirect/phpcodesniffer-composer-installer (v0.7.0 => v0.7.1): Extracting archive
  - Installing symfony/polyfill-php80 (v1.23.0): Extracting archive
  - Installing jean85/pretty-package-versions (1.6.0): Extracting archive
  - Upgrading mongodb/mongodb (1.1.0 => 1.8.0): Extracting archive
  - Upgrading alcaeus/mongo-php-adapter (1.1.0 => 1.2.0): Extracting archive
  - Upgrading nikic/php-parser (v4.13.0 => v4.15.1): Extracting archive
  - Installing brick/varexporter (0.3.5): Extracting archive
  - Installing doctrine/deprecations (v0.5.3): Extracting archive
  - Upgrading laminas/laminas-zendframework-bridge (1.0.0 => 1.2.0): Extracting archive
  - Upgrading laminas/laminas-stdlib (3.3.0 => 3.3.1): Extracting archive
  - Installing psr/container (1.1.1): Extracting archive
  - Upgrading container-interop/container-interop (1.1.0 => 1.2.0): Extracting archive
  - Upgrading laminas/laminas-servicemanager (3.1.1 => 3.6.4): Extracting archive
  - Upgrading laminas/laminas-loader (2.5.1 => 2.7.0): Extracting archive
  - Upgrading laminas/laminas-json (2.6.1 => 3.2.0): Extracting archive
  - Upgrading laminas/laminas-eventmanager (3.0.1 => 3.3.1): Extracting archive
  - Upgrading laminas/laminas-view (2.11.3 => 2.12.0): Extracting archive
  - Upgrading laminas/laminas-validator (2.10.1 => 2.14.4): Extracting archive
  - Upgrading laminas/laminas-escaper (2.5.0 => 2.7.0): Extracting archive
  - Upgrading laminas/laminas-uri (2.5.2 => 2.8.1): Extracting archive
  - Upgrading laminas/laminas-http (2.8.3 => 2.14.3): Extracting archive
  - Upgrading laminas/laminas-router (3.0.1 => 3.4.5): Extracting archive
  - Installing webimpress/safe-writer (2.2.0): Extracting archive
  - Upgrading laminas/laminas-config (2.6.0 => 3.5.0): Extracting archive
  - Upgrading laminas/laminas-modulemanager (2.7.2 => 2.10.2): Extracting archive
  - Upgrading laminas/laminas-mvc (3.0.2 => 3.2.0): Extracting archive
  - Upgrading symfony/polyfill-mbstring (v1.0.0 => v1.23.0): Extracting archive
  - Installing symfony/polyfill-intl-normalizer (v1.23.0): Extracting archive
  - Installing symfony/polyfill-intl-grapheme (v1.23.0): Extracting archive
  - Installing symfony/polyfill-ctype (v1.23.0): Extracting archive
  - Installing symfony/string (v5.3.2): Extracting archive
  - Installing symfony/service-contracts (v2.4.0): Extracting archive
  - Installing symfony/polyfill-php73 (v1.23.0): Extracting archive
  - Installing symfony/deprecation-contracts (v2.4.0): Extracting archive
  - Upgrading symfony/console (v3.4.17 => v5.3.2): Extracting archive
  - Installing psr/cache (1.0.1): Extracting archive
  - Upgrading doctrine/lexer (v1.0 => 1.2.1): Extracting archive
  - Upgrading doctrine/annotations (v1.5.0 => 1.13.1): Extracting archive
  - Upgrading doctrine/reflection (v1.0.0 => 1.2.2): Extracting archive
  - Upgrading doctrine/event-manager (v1.0.0 => 1.1.1): Extracting archive
  - Upgrading doctrine/collections (v1.4.0 => 1.6.7): Extracting archive
  - Upgrading doctrine/cache (v1.6.0 => 1.11.3): Extracting archive
  - Upgrading doctrine/persistence (v1.0.0 => 1.3.8): Extracting archive
  - Upgrading doctrine/inflector (v1.0 => 1.4.4): Extracting archive
  - Upgrading doctrine/common (v2.9.0 => 2.13.3): Extracting archive
  - Upgrading doctrine/mongodb (1.3.0 => 1.6.4): Extracting archive
  - Upgrading doctrine/instantiator (1.3.1 => 1.4.0): Extracting archive
  - Upgrading doctrine/mongodb-odm (1.1.7 => 1.3.7): Extracting archive
  - Upgrading laminas/laminas-paginator (2.7.0 => 2.10.0): Extracting archive
  - Upgrading laminas/laminas-filter (2.7.1 => 2.11.1): Extracting archive
  - Upgrading laminas/laminas-inputfilter (2.7.2 => 2.12.0): Extracting archive
  - Upgrading laminas/laminas-form (2.9.2 => 2.15.1): Extracting archive
  - Installing psr/simple-cache (1.0.1): Extracting archive
  - Upgrading zendframework/zend-cache (2.7.1 => 2.9.0): Extracting archive
  - Upgrading laminas/laminas-authentication (2.5.3 => 2.8.0): Extracting archive
  - Upgrading doctrine/doctrine-module (1.2.0 => 2.1.10): Extracting archive
  - Upgrading doctrine/doctrine-mongo-odm-module (0.11.0 => 1.1.1): Extracting archive
  - Upgrading doctrine/dbal (2.12.0 => 2.13.2): Extracting archive
  - Upgrading doctrine/orm (v2.6.3 => 2.7.5): Extracting archive
  - Upgrading doctrine/doctrine-orm-module (1.1.8 => 2.1.7): Extracting archive
  - Upgrading laminas/laminas-code (2.6.3 => 4.4.0): Extracting archive
  - Upgrading laminas-api-tools/api-tools-versioning (1.2.0 => 1.4.0): Extracting archive
  - Upgrading laminas-api-tools/api-tools-api-problem (1.2.1 => 1.4.0): Extracting archive
  - Upgrading laminas-api-tools/api-tools-content-negotiation (1.2.2 => 1.5.0): Extracting archive
  - Upgrading laminas-api-tools/api-tools-rpc (1.3.0 => 1.5.0): Extracting archive
  - Upgrading laminas/laminas-permissions-rbac (2.5.1 => 3.1.0): Extracting archive
  - Upgrading laminas/laminas-permissions-acl (2.6.0 => 2.8.0): Extracting archive
  - Upgrading webmozart/assert (1.0.0 => 1.10.0): Extracting archive
  - Upgrading laminas/laminas-i18n (2.7.3 => 2.11.1): Extracting archive
  - Installing laminas/laminas-mvc-i18n (1.2.0): Extracting archive
  - Upgrading laminas/laminas-math (2.6.0 => 3.3.2): Extracting archive
  - Upgrading laminas/laminas-crypt (2.6.0 => 3.4.0): Extracting archive
  - Upgrading bshaffer/oauth2-server-php (v1.8.0 => v1.11.1): Extracting archive
  - Upgrading laminas-api-tools/api-tools-oauth2 (1.4.0 => 1.7.2): Extracting archive
  - Upgrading laminas-api-tools/api-tools-mvc-auth (1.4.2 => 1.6.0): Extracting archive
  - Upgrading laminas-api-tools/api-tools-rest (1.3.2 => 1.6.1): Extracting archive
  - Upgrading laminas-api-tools/api-tools-provider (1.2.0 => 1.4.0): Extracting archive
  - Upgrading laminas-api-tools/api-tools-content-validation (1.3.4 => 1.9.0): Extracting archive
  - Upgrading laminas-api-tools/api-tools-configuration (1.2.1 => 1.4.1): Extracting archive
  - Upgrading laminas-api-tools/api-tools-admin-ui (1.3.7 => 1.4.0): Extracting archive
  - Upgrading laminas/laminas-db (2.8.1 => 2.12.0): Extracting archive
  - Upgrading laminas-api-tools/api-tools (1.3.0 => 1.5.0): Extracting archive
  - Upgrading laminas-api-tools/api-tools-admin (1.5.7 => 1.9.0): Extracting archive
  - Upgrading webimpress/coding-standard (1.2.0 => 1.2.2): Extracting archive
  - Upgrading phpstan/phpdoc-parser (0.5.1 => 0.5.4): Extracting archive
  - Upgrading slevomat/coding-standard (7.0.0 => 7.0.9): Extracting archive
  - Upgrading psr/log (1.0.0 => 1.1.4): Extracting archive
  - Upgrading laminas/laminas-log (2.9.1 => 2.13.1): Extracting archive
  - Upgrading laminas/laminas-serializer (2.8.0 => 2.10.1): Extracting archive
  - Upgrading sebastian/recursion-context (4.0.0 => 4.0.4): Extracting archive
  - Upgrading sebastian/object-reflector (2.0.0 => 2.0.4): Extracting archive
  - Upgrading sebastian/object-enumerator (4.0.3 => 4.0.4): Extracting archive
  - Upgrading sebastian/global-state (5.0.1 => 5.0.3): Extracting archive
  - Upgrading sebastian/diff (4.0.3 => 4.0.4): Extracting archive
  - Upgrading sebastian/code-unit (1.0.6 => 1.0.8): Extracting archive
  - Upgrading phpunit/php-timer (5.0.2 => 5.0.3): Extracting archive
  - Upgrading phpunit/php-text-template (2.0.3 => 2.0.4): Extracting archive
  - Upgrading sebastian/complexity (2.0.0 => 2.0.2): Extracting archive
  - Upgrading sebastian/code-unit-reverse-lookup (2.0.2 => 2.0.3): Extracting archive
  - Upgrading phpunit/php-code-coverage (9.2.13 => 9.2.18): Extracting archive
  - Upgrading phar-io/version (3.0.2 => 3.1.0): Extracting archive
  - Upgrading myclabs/deep-copy (1.10.1 => 1.10.2): Extracting archive
  - Upgrading laminas/laminas-dom (2.6.0 => 2.8.0): Extracting archive
  - Upgrading laminas/laminas-console (2.6.0 => 2.8.0): Extracting archive
  - Upgrading laminas/laminas-test (3.4.0 => 3.5.1): Extracting archive
  - Upgrading phpdocumentor/reflection-common (1.0 => 2.2.0): Extracting archive
  - Upgrading phpdocumentor/type-resolver (0.4.0 => 1.4.0): Extracting archive
  - Upgrading phpdocumentor/reflection-docblock (4.0.0 => 5.2.2): Extracting archive
  - Upgrading phpro/zf-doctrine-hydration-module (v3.0.0 => v4.1.0): Extracting archive
  - Upgrading phpspec/prophecy (v1.10.2 => 1.13.0): Extracting archive
  - Upgrading phpspec/prophecy-phpunit (v2.0.0 => v2.0.1): Extracting archive
  - Upgrading netresearch/jsonmapper (v1.0.0 => v4.0.0): Extracting archive
  - Upgrading felixfbecker/language-server-protocol (v1.5.0 => 1.5.1): Extracting archive
  - Upgrading felixfbecker/advanced-json-rpc (v3.0.3 => v3.2.1): Extracting archive
  - Upgrading composer/xdebug-handler (1.1.0 => 2.0.1): Extracting archive
  - Upgrading composer/semver (1.4.0 => 3.2.5): Extracting archive
  - Upgrading amphp/amp (v2.4.2 => v2.5.2): Extracting archive
  - Upgrading amphp/byte-stream (v1.5.0 => v1.8.1): Extracting archive
  - Upgrading vimeo/psalm (4.8.0 => 4.8.1): Extracting archive
  - Removing symfony/yaml (v2.3.0)
 107/119 [=========================>--]  89%  - Installing symfony/yaml (v5.3.2): Extracting archive
Package container-interop/container-interop is abandoned, you should avoid using it. Use psr/container instead.
Package doctrine/reflection is abandoned, you should avoid using it. Use roave/better-reflection instead.
Package zendframework/zend-cache is abandoned, you should avoid using it. Use laminas/laminas-cache instead.
Package doctrine/mongodb is abandoned, you should avoid using it. No replacement was suggested.
Package laminas/laminas-console is abandoned, you should avoid using it. Use laminas/laminas-cli instead.
Generating autoload files
99 packages you are using are looking for funding.
Use the `composer fund` command to find out more!

@javabudd

javabudd commented Nov 1, 2022 •
edited
Loading

Copy link
Copy Markdown
Author

PHPCodeSniffer and Psalm checks are failing due to legitimate issues with the code. I will ignore those for now and we can address that in a separate PR. PHP8 lowest/latest builds are still failing and I'm not entirely sure why, will look into it.

@javabudd

javabudd commented Nov 1, 2022 •
edited
Loading

Copy link
Copy Markdown
Author

In order to get PHP8 builds working we need to allow doctrine-module @ ^4.0 and replace phpro/zf-doctrine-hydration-module with something like doctrine/doctrine-laminas-hydrator. Not sure how to proceed with this one.

@javabudd javabudd mentioned this pull request Nov 2, 2022
Closed
@javabudd

javabudd commented Feb 21, 2023

Copy link
Copy Markdown
Author

Declining in favor of #35

@javabudd javabudd closed this Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Awaiting Maintainer Response Enhancement New feature or request

Projects

None yet

Milestone

2.5.0

Development

Successfully merging this pull request may close these issues.

2 participants

@javabudd @Ocramius