fix - loadModule reinitializes modules if the module has already been… - #34
Open
nusphere wants to merge 3 commits into
Open
fix - loadModule reinitializes modules if the module has already been…#34nusphere wants to merge 3 commits into
nusphere wants to merge 3 commits into
Conversation
… loaded laminas#32 Signed-off-by: Sebastian Hopfe <sebastian.hopfe@milchundzucker.de>
… loaded laminas#32 Signed-off-by: Sebastian Hopfe <sebastian.hopfe@milchundzucker.de>
Signed-off-by: Sebastian Hopfe <sebastian.hopfe@milchundzucker.de>
Author
|
any review possible? |
Member
|
@Xerkus |
|
Hi. Is there anything holding this fix back? The |
Author
|
@froschdesign - ping |
froschdesign
requested changes
Dec 8, 2022
froschdesign
left a comment
froschdesign
left a comment
Member
There was a problem hiding this comment.
Please use the current release branch for this bugfix: 2.14.x
Comment on lines
+103
to
+129
| public function testModuleLoadingBehaviorWithModuleClassStrings() | ||
| { | ||
| $moduleManager = new ModuleManager(['SomeModule'], $this->events); | ||
| $this->defaultListeners->attach($this->events); | ||
| $modules = $moduleManager->getLoadedModules(); | ||
| self::assertSame(0, count($modules)); | ||
| $modules = $moduleManager->getLoadedModules(true); | ||
| self::assertSame(1, count($modules)); | ||
| $moduleManager->loadModules(); // should not cause any problems | ||
| $moduleManager->loadModule(Module::class); // should not cause any problems | ||
| $modules = $moduleManager->getLoadedModules(true); // BarModule already loaded so nothing happens | ||
| self::assertSame(1, count($modules)); | ||
| } | ||
|
|
||
| public function testModuleLoadingBehaviorWithModuleClassStringsVersion2() | ||
| { | ||
| $moduleManager = new ModuleManager([Module::class], $this->events); | ||
| $this->defaultListeners->attach($this->events); | ||
| $modules = $moduleManager->getLoadedModules(); | ||
| self::assertSame(0, count($modules)); | ||
| $modules = $moduleManager->getLoadedModules(true); | ||
| self::assertSame(1, count($modules)); | ||
| $moduleManager->loadModules(); // should not cause any problems | ||
| $moduleManager->loadModule('SomeModule'); // should not cause any problems | ||
| $modules = $moduleManager->getLoadedModules(true); // BarModule already loaded so nothing happens | ||
| self::assertSame(1, count($modules)); | ||
| } |
Member
There was a problem hiding this comment.
Please use a data provider here and add some blank lines to break the wall of code / text.
| * @param string $moduleName | ||
| * @return string | ||
| */ | ||
| private function getVerifiedModuleName($moduleName) |
Member
There was a problem hiding this comment.
Add the types to the method because it is private and supported.
Member
|
No matter how I look at this there is a BC break in any fix. It is incredibly brittle and was around for so long this way it is almost not worth fixing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As descripted in #32 . there is an bug when loading a module with another loading name. there are currently 3 ways to load the same module via the module manager. the following options are available:
if you use method 1 (namespace) and method 2 (class string) for the same module in an application, it will be loaded twice and reset the previous settings.
this pull request fixes the false behavior and prevents a module from being loaded twice.
fixes #32