Sync main with upstream lightningdevkit/ldk-node (86 commits)

.github/workflows/audit.yml

@@ -6,6 +6,7 @@ on:
 
 jobs:
   audit:
+    timeout-minutes: 60
     permissions:
       issues: write
       checks: write

.github/workflows/benchmarks.yml

@@ -8,25 +8,27 @@ concurrency:
 
 jobs:
   benchmark:
-    runs-on: ubuntu-latest
+    timeout-minutes: 60
+    runs-on: self-hosted
     env:
       TOOLCHAIN: stable
     steps:
       - name: Checkout source code
-        uses: actions/checkout@v6
+        uses: actions/checkout@v4
       - name: Install Rust toolchain
         run: |
           curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain stable
-          rustup override set stable
+      - name: Set Rust override
+        run: rustup override set stable
       - name: Enable caching for bitcoind
         id: cache-bitcoind
-        uses: actions/cache@v5
+        uses: actions/cache@v4
         with:
           path: bin/bitcoind-${{ runner.os }}-${{ runner.arch }}
           key: bitcoind-29.0-${{ runner.os }}-${{ runner.arch }}
       - name: Enable caching for electrs
         id: cache-electrs
-        uses: actions/cache@v5
+        uses: actions/cache@v4
         with:
           path: bin/electrs-${{ runner.os }}-${{ runner.arch }}
           key: electrs-${{ runner.os }}-${{ runner.arch }}

.github/workflows/cln-integration.yml

@@ -8,6 +8,7 @@ concurrency:
 
 jobs:
   check-cln:
+    timeout-minutes: 60
     runs-on: ubuntu-latest
     steps:
       - name: Checkout repository

.github/workflows/cron-weekly-rustfmt.yml

@@ -11,7 +11,8 @@ on:
 jobs:
   format:
     name: Nightly rustfmt
-    runs-on: ubuntu-24.04
+    timeout-minutes: 60
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v6
       - uses: dtolnay/rust-toolchain@nightly

.github/workflows/eclair-integration.yml

@@ -8,6 +8,7 @@ concurrency:
 
 jobs:
   check-eclair:
+    timeout-minutes: 60
     runs-on: ubuntu-latest
     steps:
       - name: Checkout repository

.github/workflows/hrn-integration.yml

@@ -8,7 +8,8 @@ concurrency:
 
 jobs:
   build-and-test:
-    runs-on: ubuntu-latest
+    timeout-minutes: 60
+    runs-on: self-hosted
 
     steps:
       - name: Checkout source code
@@ -42,4 +43,4 @@ jobs:
       - name: Run HRN Integration Tests
         run: |
           RUSTFLAGS="--cfg no_download --cfg hrn_tests $RUSTFLAGS" cargo test --test integration_tests_hrn
-          RUSTFLAGS="--cfg no_download --cfg hrn_tests $RUSTFLAGS" cargo test --test integration_tests_hrn --features uniffi
+          RUSTFLAGS="--cfg no_download --cfg hrn_tests $RUSTFLAGS" cargo test --test integration_tests_hrn --features uniffi

.github/workflows/kotlin.yml

@@ -8,6 +8,7 @@ concurrency:
 
 jobs:
   check-kotlin:
+    timeout-minutes: 60
     runs-on: ubuntu-latest
 
     env:

.github/workflows/lnd-integration.yml

@@ -8,6 +8,7 @@ concurrency:
 
 jobs:
   check-lnd:
+    timeout-minutes: 60
     runs-on: ubuntu-latest
     steps:
       - name: Checkout repository

.github/workflows/python.yml

@@ -8,6 +8,7 @@ concurrency:
 
 jobs:
   check-python:
+    timeout-minutes: 60
     runs-on: ubuntu-latest
 
     env:

.github/workflows/rust.yml

@@ -8,10 +8,11 @@ concurrency:
 
 jobs:
   build:
+    timeout-minutes: 60
     strategy:
       matrix:
         platform: [
-          ubuntu-latest,
+          self-hosted,
           macos-latest,
           windows-latest,
           ]
@@ -24,7 +25,7 @@ jobs:
           - toolchain: stable
             check-fmt: true
             build-uniffi: true
-            platform: ubuntu-latest
+            platform: self-hosted
           - toolchain: stable
             platform: macos-latest
           - toolchain: stable
@@ -34,7 +35,7 @@ jobs:
     runs-on: ${{ matrix.platform }}
     steps:
       - name: Checkout source code
-        uses: actions/checkout@v6
+        uses: actions/checkout@v4
       - name: Install Rust ${{ matrix.toolchain }} toolchain
         run: |
           curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain ${{ matrix.toolchain }}
@@ -50,13 +51,13 @@ jobs:
         run: echo "RUSTFLAGS=-D warnings" >> "$GITHUB_ENV"
       - name: Enable caching for bitcoind
         id: cache-bitcoind
-        uses: actions/cache@v5
+        uses: actions/cache@v4
         with:
           path: bin/bitcoind-${{ runner.os }}-${{ runner.arch }}
           key: bitcoind-29.0-${{ runner.os }}-${{ runner.arch }}
       - name: Enable caching for electrs
         id: cache-electrs
-        uses: actions/cache@v5
+        uses: actions/cache@v4
         with:
           path: bin/electrs-${{ runner.os }}-${{ runner.arch }}
           key: electrs-${{ runner.os }}-${{ runner.arch }}
@@ -92,26 +93,29 @@ jobs:
 
   linting:
     name: Linting
-    runs-on: ubuntu-latest
+    timeout-minutes: 60
+    runs-on: self-hosted
     steps:
       - name: Checkout source code
-        uses: actions/checkout@v6
-      - name: Install Rust and clippy
+        uses: actions/checkout@v4
+      - name: Install Rust stable toolchain
         run: |
           curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain stable
-          rustup component add clippy
+      - name: Add clippy component
+        run: rustup component add clippy
       - name: Ban `unwrap` in library code
         run: |
           cargo clippy --lib --verbose --color always -- -A warnings -D clippy::unwrap_used -A clippy::tabs_in_doc_comments
           cargo clippy --lib --features uniffi --verbose --color always -- -A warnings -D clippy::unwrap_used -A clippy::tabs_in_doc_comments
 
   doc:
     name: Documentation
-    runs-on: ubuntu-latest
+    timeout-minutes: 60
+    runs-on: self-hosted
     env:
       RUSTDOCFLAGS: -Dwarnings
     steps:
-      - uses: actions/checkout@v6
+      - uses: actions/checkout@v4
       - uses: dtolnay/rust-toolchain@nightly
       - uses: dtolnay/install@cargo-docs-rs
       - run: cargo docs-rs

.github/workflows/semver.yml

@@ -3,6 +3,7 @@ on: [push, pull_request]
 
 jobs:
   semver-checks:
+    timeout-minutes: 60
     runs-on: ubuntu-latest
     steps:
       - name: Checkout source code

.github/workflows/swift.yml

@@ -8,6 +8,7 @@ concurrency:
 
 jobs:
   check-swift:
+    timeout-minutes: 60
     runs-on: macos-latest
 
     steps:

.github/workflows/vss-integration.yml

@@ -8,6 +8,7 @@ concurrency:
 
 jobs:
   build-and-test:
+    timeout-minutes: 60
     runs-on: ubuntu-latest
 
     services:

.github/workflows/vss-no-auth-integration.yml

@@ -8,6 +8,7 @@ concurrency:
 
 jobs:
   build-and-test:
+    timeout-minutes: 60
     runs-on: ubuntu-latest
 
     services:

CHANGELOG.md

@@ -3,6 +3,25 @@
 ## Compatibility Notes
 - Pending JIT-channel payments created before upgrading may fail after upgrade because the
   prior LSPS2 fee-limit state stored in `PaymentKind::Bolt11Jit` is not migrated.
+- Users of the VSS storage backend must upgrade their VSS server to at least version
+  `v0.1.0-alpha.0` before upgrading LDK Node.
+
+## Feature and API updates
+- The Bitcoin Core RPC and REST chain-source builder methods now accept an optional
+  `wallet_rescan_from_height` argument. Passing a height lets fresh wallets rescan from a known
+  birthday block instead of checkpointing at the current tip, which is useful when restoring a
+  wallet on a pruned node where the full history is unavailable but the wallet birthday height is
+  known. Existing wallets are not rewound, and future heights fail the build. Passing `Some(0)`
+  rescans from genesis; passing `None` keeps the default current-tip checkpoint behavior. (#884)
+- `EsploraSyncConfig` and `ElectrumSyncConfig` now support `force_wallet_full_scan`. When set,
+  the on-chain wallet keeps using BDK `full_scan` instead of incremental sync until a full scan
+  succeeds, allowing restored wallets to rediscover funds sent to previously-unknown addresses.
+
+## Bug Fixes and Improvements
+- Building a fresh node against a Bitcoin Core RPC or REST chain source that fails to return the
+  current chain tip now aborts with a new `BuildError::ChainTipFetchFailed` variant instead of
+  silently pinning the wallet birthday to genesis, which would have forced a full-history rescan
+  once the chain source became reachable again. (#884)
 
 # 0.7.0 - Dec. 3, 2025
 This seventh minor release introduces numerous new features, bug fixes, and API improvements. In particular, it adds support for channel Splicing, Async Payments, as well as sourcing chain data from a Bitcoin Core REST backend.

Cargo.toml

@@ -54,10 +54,10 @@ lightning-liquidity = { git = "https://github.com/lightningdevkit/rust-lightning
 lightning-macros = { git = "https://github.com/lightningdevkit/rust-lightning", rev = "3dfcc4cca1866c5e5d4d4eaf3b82e09584e2ce5c" }
 lightning-dns-resolver = { git = "https://github.com/lightningdevkit/rust-lightning", rev = "3dfcc4cca1866c5e5d4d4eaf3b82e09584e2ce5c" }
 
-bdk_chain = { version = "0.23.0", default-features = false, features = ["std"] }
-bdk_esplora = { version = "0.22.0", default-features = false, features = ["async-https-rustls", "tokio"]}
+bdk_chain = { version = "0.23.3", default-features = false, features = ["std"] }
+bdk_esplora = { version = "0.22.2", default-features = false, features = ["async-https-rustls", "tokio"]}
 bdk_electrum = { version = "0.24.0", default-features = false, features = ["use-rustls-ring"]}
-bdk_wallet = { version = "2.3.0", default-features = false, features = ["std", "keys-bip39"]}
+bdk_wallet = { version = "3.1.0", default-features = false, features = ["std", "keys-bip39"]}
 
 bitreq = { version = "0.3", default-features = false, features = ["async-https", "json-using-serde"] }
 rustls = { version = "0.23", default-features = false }
@@ -69,7 +69,7 @@ bip21 = { version = "0.5", features = ["std"], default-features = false }
 base64 = { version = "0.22.1", default-features = false, features = ["std"] }
 getrandom = { version = "0.3", default-features = false }
 chrono = { version = "0.4", default-features = false, features = ["clock"] }
-tokio = { version = "1.37", default-features = false, features = [ "rt-multi-thread", "time", "sync", "macros", "net" ] }
+tokio = { version = "1.39", default-features = false, features = [ "rt-multi-thread", "time", "sync", "macros", "net" ] }
 esplora-client = { version = "0.12", default-features = false, features = ["tokio", "async-https-rustls"] }
 electrum-client = { version = "0.25", default-features = false, features = ["proxy", "use-rustls-ring"] }
 libc = "0.2"
@@ -82,7 +82,7 @@ async-trait = { version = "0.1", default-features = false }
 tokio-postgres = { version = "0.7", default-features = false, features = ["runtime"], optional = true }
 native-tls = { version = "0.2", default-features = false, optional = true }
 postgres-native-tls = { version = "0.5", default-features = false, features = ["runtime"], optional = true }
-vss-client = { package = "vss-client-ng", version = "0.5" }
+vss-client = { package = "vss-client-ng", version = "0.6" }
 prost = { version = "0.11.6", default-features = false}
 #bitcoin-payment-instructions = { version = "0.6" }
 bitcoin-payment-instructions = { git = "https://github.com/tnull/bitcoin-payment-instructions", rev = "ff09ce9401afa448549a8f101172700bcd14d7bb" }
@@ -92,6 +92,7 @@ winapi = { version = "0.3", features = ["winbase"] }
 
 [dev-dependencies]
 lightning = { git = "https://github.com/lightningdevkit/rust-lightning", rev = "3dfcc4cca1866c5e5d4d4eaf3b82e09584e2ce5c", features = ["std", "_test_utils"] }
+lightning-persister = { git = "https://github.com/lightningdevkit/rust-lightning", rev = "3dfcc4cca1866c5e5d4d4eaf3b82e09584e2ce5c", features = ["tokio"] }
 rand = { version = "0.9.2", default-features = false, features = ["std", "thread_rng", "os_rng"] }
 proptest = "1.0.0"
 regex = "1.5.6"

README.md

@@ -62,10 +62,14 @@ LDK Node currently comes with a decidedly opinionated set of design choices:
 
 - On-chain data is handled by the integrated [BDK][bdk] wallet.
 - Chain data may currently be sourced from the Bitcoin Core RPC interface, or from an [Electrum][electrum] or [Esplora][esplora] server.
-- Wallet and channel state may be persisted to an [SQLite][sqlite] database, to file system, or to a custom back-end to be implemented by the user.
+- Wallet and channel state may be persisted to an [SQLite][sqlite] or [PostgreSQL][postgresql] database, to file system, or to a custom back-end to be implemented by the user.
 - Gossip data may be sourced via Lightning's peer-to-peer network or the [Rapid Gossip Sync](https://docs.rs/lightning-rapid-gossip-sync/*/lightning_rapid_gossip_sync/) protocol.
 - Entropy for the Lightning and on-chain wallets may be sourced from raw bytes or a [BIP39](https://github.com/bitcoin/bips/blob/master/bip-0039.mediawiki) mnemonic. In addition, LDK Node offers the means to generate and persist the entropy bytes to disk.
 
+## Compatibility
+
+LDK Node does not provide a stable public API until v1.0. Persisted node state is backwards compatible: newer releases are guaranteed to load state written by older releases. Downgrades are not supported, so state written by a newer release may not load with an older release.
+
 ## Language Support
 LDK Node itself is written in [Rust][rust] and may therefore be natively added as a library dependency to any `std` Rust program. However, beyond its Rust API it also offers language bindings for [Swift][swift], [Kotlin][kotlin], and [Python][python] based on the [UniFFI](https://github.com/mozilla/uniffi-rs/).
 
@@ -81,6 +85,7 @@ The Minimum Supported Rust Version (MSRV) is currently 1.85.0.
 [electrum]: https://github.com/spesmilo/electrum-protocol
 [esplora]: https://github.com/Blockstream/esplora
 [sqlite]: https://sqlite.org/
+[postgresql]: https://www.postgresql.org/
 [rust]: https://www.rust-lang.org/
 [swift]: https://www.swift.org/
 [kotlin]: https://kotlinlang.org/

bindings/ldk_node.udl

@@ -38,13 +38,12 @@ interface Builder {
 	constructor(Config config);
 	void set_chain_source_esplora(string server_url, EsploraSyncConfig? config);
 	void set_chain_source_electrum(string server_url, ElectrumSyncConfig? config);
-	void set_chain_source_bitcoind_rpc(string rpc_host, u16 rpc_port, string rpc_user, string rpc_password);
-	void set_chain_source_bitcoind_rest(string rest_host, u16 rest_port, string rpc_host, u16 rpc_port, string rpc_user, string rpc_password);
+	void set_chain_source_bitcoind_rpc(string rpc_host, u16 rpc_port, string rpc_user, string rpc_password, u32? wallet_rescan_from_height);
+	void set_chain_source_bitcoind_rest(string rest_host, u16 rest_port, string rpc_host, u16 rpc_port, string rpc_user, string rpc_password, u32? wallet_rescan_from_height);
 	void set_gossip_source_p2p();
 	void set_gossip_source_rgs(string rgs_server_url);
 	void set_pathfinding_scores_source(string url);
-	void set_liquidity_source_lsps1(PublicKey node_id, SocketAddress address, string? token);
-	void set_liquidity_source_lsps2(PublicKey node_id, SocketAddress address, string? token);
+	void add_liquidity_source(PublicKey node_id, SocketAddress address, string? token, boolean trust_peer_0conf);
 	void set_storage_dir_path(string storage_dir_path);
 	void set_filesystem_logger(string? log_file_path, LogLevel? max_log_level);
 	void set_log_facade_logger();
@@ -60,7 +59,6 @@ interface Builder {
 	void set_node_alias(string node_alias);
 	[Throws=BuildError]
 	void set_async_payments_role(AsyncPaymentsRole? role);
-	void set_wallet_recovery_mode();
 	[Throws=BuildError]
 	Node build(NodeEntropy node_entropy);
 	[Throws=BuildError]
@@ -99,7 +97,7 @@ interface Node {
 	SpontaneousPayment spontaneous_payment();
 	OnchainPayment onchain_payment();
 	UnifiedPayment unified_payment();
-	LSPS1Liquidity lsps1_liquidity();
+	Liquidity liquidity();
 	[Throws=NodeError]
 	void lnurl_auth(string lnurl);
 	[Throws=NodeError]
@@ -125,6 +123,8 @@ interface Node {
 	[Throws=NodeError]
 	void splice_out([ByRef]UserChannelId user_channel_id, PublicKey counterparty_node_id, [ByRef]Address address, u64 splice_amount_sats);
 	[Throws=NodeError]
+	void bump_channel_funding_fee([ByRef]UserChannelId user_channel_id, PublicKey counterparty_node_id);
+	[Throws=NodeError]
 	void close_channel([ByRef]UserChannelId user_channel_id, PublicKey counterparty_node_id);
 	[Throws=NodeError]
 	void force_close_channel([ByRef]UserChannelId user_channel_id, PublicKey counterparty_node_id, string? reason);
@@ -167,7 +167,7 @@ interface FeeRate {
 
 typedef interface UnifiedPayment;
 
-typedef interface LSPS1Liquidity;
+typedef interface Liquidity;
 
 [Error]
 enum NodeError {
@@ -275,6 +275,7 @@ dictionary LSPS1OrderStatus {
 	LSPS1OrderParams order_params;
 	LSPS1PaymentInfo payment_options;
 	LSPS1ChannelInfo? channel_state;
+	PublicKey counterparty_node_id;
 };
 
 [Remote]