Skip to content

another attempts at jitterentropy issue#41

Merged
yuvalif merged 1 commit intolancedb:mainfrom
yuvalif:wip-fix-jitterentropy-build2
Apr 16, 2026
Merged

another attempts at jitterentropy issue#41
yuvalif merged 1 commit intolancedb:mainfrom
yuvalif:wip-fix-jitterentropy-build2

Conversation

@yuvalif
Copy link
Copy Markdown
Collaborator

@yuvalif yuvalif commented Apr 16, 2026

No description provided.

@yuvalif yuvalif force-pushed the wip-fix-jitterentropy-build2 branch 3 times, most recently from 4b68146 to bf5d8a8 Compare April 16, 2026 15:28
@yuvalif yuvalif requested a review from Copilot April 16, 2026 16:26
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to address build issues related to jitterentropy by reverting a prior Rust build tweak and disabling _FORTIFY_SOURCE (likely to avoid failures on RHEL-like distros).

Changes:

  • Removed the dev-profile opt-level override for aws-lc-sys.
  • Replaced the Fedora container CI job with an AlmaLinux 9 container job and adjusted Arrow installation.
  • Added a Cargo config to set CFLAGS=-U_FORTIFY_SOURCE.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
Cargo.toml Removes a package-specific dev profile override for aws-lc-sys.
.github/workflows/ci.yml Switches container CI coverage from Fedora to AlmaLinux 9 and installs Arrow via an RPM repo.
.cargo/config.toml Globally injects CFLAGS to undefine _FORTIFY_SOURCE.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .cargo/config.toml
Comment thread .github/workflows/ci.yml
Comment thread .github/workflows/ci.yml Outdated
* revert the fix from 8cfb145
* disable _FORTIFY_SOURCE flag used in centos9 and rocky10
* use AlmaLinux9 in CI (apache arrow support it)

Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
@yuvalif yuvalif force-pushed the wip-fix-jitterentropy-build2 branch from bf5d8a8 to dcac296 Compare April 16, 2026 16:59
@yuvalif yuvalif merged commit 6c19ed1 into lancedb:main Apr 16, 2026
7 checks passed
yuvalif added a commit to ceph/ceph-ci that referenced this pull request Apr 16, 2026
see: lancedb/lancedb-c#41

Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants