test: build SDK quality test suite#65
Merged
Merged
Conversation
This was referenced May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Builds the SDK quality test suite and resolves the source issues that were recorded by that suite.
test-buildsuite.xfailmarkers for those blockers; the recorded issue tests now run normally and pass.Fixed Issues
ComponentDiscoveryEngineregistries per instance.ActionCallErrormessages instead of wrapping them twice.CommandReturnserialization safe.ContentElement(type="image_url")requires animage_urlpayload.PluginContainerdict roundtrips.PluginManagerplugin/plugin-handler state per instance.PluginManager.emit_event.Validation
SDK Test Suite
The previous blockers are no longer skipped or xfailed.
rg "xfail|skip\\(" tests srcreturns no matches in this branch.LangBot Master Smoke And E2E
Validated the SDK against a clean LangBot master worktree:
767137a9723b59uv pip install -e /home/glwuy/langbot-app/langbot-plugin-sdk-test-build.langbot_plugin.__file__resolves to the local SDK source tree, not the locked/published package.LangBot test commands:
Browser e2e smoke:
qa/plugin-smokewith the same SDK under test.Plugins -> Upload Local.QA Plugin Smoke,Tool 1, andPage 1.Smoke Pageiframe and verified the sentinel textqa-plugin-smoke-page.GET /api/v1/pluginsincludes initializedqa/plugin-smoke.GET /api/v1/toolsincludesqa_echo.POST /api/v1/plugins/qa/plugin-smoke/page-apifor/pingreturnsqa-plugin-smoke-page.Note: LangBot validation uses
uv run --no-syncafter installing the editable local SDK. Plainuv runmay sync fromuv.lockand replace the local SDK with the locked package, which would invalidate the test.