fix(quickjs): forward config for skills and PTC tools#554
Open
Luiz Eduardo Zappa (luizzappa) wants to merge 5 commits into
Open
fix(quickjs): forward config for skills and PTC tools#554Luiz Eduardo Zappa (luizzappa) wants to merge 5 commits into
Luiz Eduardo Zappa (luizzappa) wants to merge 5 commits into
Conversation
🦋 Changeset detectedLatest commit: dc5fec9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
deepagents-acp
deepagents
@langchain/sandbox-standard-tests
@langchain/daytona
@langchain/deno
@langchain/modal
@langchain/node-vfs
@langchain/quickjs
commit: |
Hunter Lovell (hntrl)
approved these changes
Jun 2, 2026
Comment on lines
+644
to
+646
| setToolConfig(config?: RunnableConfig): void { | ||
| this.toolConfig = config; | ||
| } |
Member
There was a problem hiding this comment.
FWIW I think this might cause some issues with how we handle parallel eval calling. Its something we have to guard against at the emscripten boundary but if we make enhancements there this becomes problematic. We'll probably be addressing sometime soon so I'll try to keep this top of mind
|
Hello! Any blockers to merging this? I just hit this gap when trying to add tools to PTC that have different behavior based on the runtime context. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #553.
createCodeInterpreterMiddleware()had two places where the LangGraph runnable config was available but not forwarded:skillsBackendsetup pathawait tools.task(...)In the first case,
getCurrentTaskInput()fell back toAsyncLocalStorage, which breaks in browser/web environments whereAsyncLocalStorageis unavailable or stubbed.In the second case, bridged tools were invoked without graph runtime config, which breaks tools that need current graph state, such as DeepAgents’
tasktool.Changes
prepareSkillsForEval()getCurrentTaskInput(config)in the quickjs skills backend pathReplSessiont.invoke(rawInput, config)tools.*receives the eval configWhy
This allows QuickJS skills and PTC tools to work in browser/web builds and preserves graph runtime context for tools called from inside the interpreter.