Skip to content

style: format with vp fmt#38803

Merged
hyoban merged 3 commits into
mainfrom
0712-vp-fmt-baseline
Jul 12, 2026
Merged

style: format with vp fmt#38803
hyoban merged 3 commits into
mainfrom
0712-vp-fmt-baseline

Conversation

@hyoban

@hyoban hyoban commented Jul 12, 2026

Copy link
Copy Markdown
Member

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Follow-up to #38705.

This PR applies the repository-wide Vite+ vp fmt baseline after the formatter configuration landed.

  • Format 6,210 frontend, CLI, E2E, package, and Node.js SDK files from the latest main.
  • Align the newly added packages/dify-ui ESLint config with the Oxfmt boundary: disable formatter-covered/conflicting rules while preserving strict semantic, React, accessibility, and Tailwind validation.
  • Fix formatter-sensitive ESLint and TypeScript suppression placement without changing runtime behavior.
  • Re-enable the CI format check, frontend contract generation, ESLint autofix, and vp fmt autofix steps that were deferred in chore: migrate formatting to vp fmt #38705.

The changes remain split into a formatting commit and a small migration-completion commit.

No associated issue was provided.

Screenshots

Before After
N/A N/A

Validation

  • pnpm install --frozen-lockfile --ignore-scripts
  • vp fmt --check (8,538 files)
  • pnpm lint:ci
  • pnpm --dir cli lint
  • pnpm --dir sdks/nodejs-client lint
  • pnpm --dir packages/dify-ui lint
  • pnpm type-check
  • pnpm --dir sdks/nodejs-client test (104 tests)
  • pnpm --dir packages/dify-ui test (256 tests)
  • pnpm --dir packages/contracts gen-api-contract (no diff)
  • git diff --check

No dedicated tests were added because this PR establishes a formatting baseline. Documentation was updated in #38705.

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and cd web && pnpm exec vp staged (frontend) to appease the lint gods

From Codex

@github-actions github-actions Bot added web This relates to changes on the web. e2e End-to-end tests and E2E test infrastructure. labels Jul 12, 2026
@codecov

codecov Bot commented Jul 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.82915% with 73 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.84%. Comparing base (b54107e) to head (0f5cab8).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cli/src/util/browser.ts 14.28% 6 Missing ⚠️
cli/src/commands/_shared/authed-command.ts 0.00% 5 Missing ⚠️
cli/src/commands/import/studio-app/index.ts 0.00% 4 Missing ⚠️
cli/src/store/store.ts 75.00% 4 Missing ⚠️
cli/src/commands/auth/login/login.ts 86.95% 3 Missing ⚠️
cli/src/commands/run/app/hitl-render.ts 85.71% 3 Missing ⚠️
cli/src/commands/run/app/input-flags.ts 40.00% 3 Missing ⚠️
cli/src/commands/run/app/stream-handlers.ts 86.95% 3 Missing ⚠️
cli/src/sys/io/color.ts 57.14% 3 Missing ⚠️
cli/src/util/host.ts 57.14% 3 Missing ⚠️
... and 24 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #38803      +/-   ##
==========================================
+ Coverage   85.54%   85.84%   +0.30%     
==========================================
  Files        5180     5180              
  Lines      277823   276725    -1098     
  Branches    52321    54518    +2197     
==========================================
- Hits       237654   237563      -91     
+ Misses      35679    34671    -1008     
- Partials     4490     4491       +1     
Flag Coverage Δ
api 85.65% <ø> (+<0.01%) ⬆️
cli 89.37% <90.82%> (+0.82%) ⬆️
dify-ui 95.41% <ø> (+0.81%) ⬆️
web 85.91% <ø> (+0.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hyoban hyoban marked this pull request as ready for review July 12, 2026 15:49
@dosubot dosubot Bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jul 12, 2026
@hyoban hyoban enabled auto-merge July 12, 2026 15:50
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jul 12, 2026
@hyoban hyoban added this pull request to the merge queue Jul 12, 2026
Merged via the queue into main with commit a84c2d3 Jul 12, 2026
44 checks passed
@hyoban hyoban deleted the 0712-vp-fmt-baseline branch July 12, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e End-to-end tests and E2E test infrastructure. lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants