refactor(protocol): enforce abstract contracts and static checks#137
Closed
QuantumGhost wants to merge 2 commits into
Closed
refactor(protocol): enforce abstract contracts and static checks#137QuantumGhost wants to merge 2 commits into
QuantumGhost wants to merge 2 commits into
Conversation
Contributor
Author
|
The massive |
Contributor
Author
|
superseded by #138 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI Disclosure: This PR was generated with Codex and GPT-5.5.
Important
!Related Issue
Closes #136
Summary
@abstractmethodto protocol members that previously lacked it acrosssrc/graphonprotocol definitions.if TYPE_CHECKING) for in-repo protocol implementations, following the_assert_readonly_variable_poolpattern.tests/test_protocol_abstract_contracts.pyto enforce protocol abstraction rules and guard against accidental implementation via partial or indirect subclassing.if TYPE_CHECKINGassertion blocks.Validation run:
uv run ruff check src tests/test_protocol_abstract_contracts.pyuv run pytest tests/test_protocol_abstract_contracts.py tests/test_protocols_exports.py tests/graph_engine/test_response_coordinator.py tests/nodes/test_human_input_runtime_binding.py tests/nodes/human_input/test_human_input_node.py tests/nodes/human_input/test_human_input_node_internal.pyChecklist
!