fix(runtime): enforce package manager capabilities#48
Open
AsperforMias wants to merge 3 commits into
Open
Conversation
b18e58a to
a5a6068
Compare
Author
|
ask for review to confirm @Yevanchen |
Author
|
稍等,有些和 #49 重复了 |
a5a6068 to
3c619c8
Compare
9382ae6 to
944c07d
Compare
Author
|
@vanillaxy could u plz review this , especially the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npmandpipas the package managers guaranteed by the maintained runtime image.python/python3andpip/python -m pipresolve coherently without duplicating base-image or Ubuntu package versions in Docker arguments.main, including feat(runtime): inject artifact paths into child process env #49 runtime path projection and fix(acp): fail empty completed turns #50 ACP behavior.Why
EXPECTED_*values would duplicate versions produced by the pinned base image and mutable Ubuntu repositories. The maintained boundary is executable availability, valid version reporting, coherent aliases, and a real pinned-package smoke test.Verification
bun run lint,bun run tc, andbun run build: passed.bun run test:205passed and4credential-backed live tests skipped.6passed.17passed across the path projection and provider launch paths.just check: passed formatting, docs links, lint, typecheck, all workspace tests, and GraphQL freshness; API reported1022tests across172files.44passed.bun run docker:smoke:environment: installed and executedprettier@3.3.3andsix==1.16.0from temporary isolated prefixes.npm failed: spawnSync npm ENOENT.npm returned an invalid version: not-a-version.Environment package manager has no verify check: cargo.@cloudflare/sandboxDurable Object path.3.3.3,3.3.3, and1.16.0.Source logic, the #337 reproduction path, and the local Worker/Sandbox/R2/Driver injection chain demonstrate that the runtime capability fix is effective. The unverified boundary is remote Cloudflare platform integration behavior, not the issue's package-manager consistency contract.
Impact
environment-package-managers.jsonas the Driver-owned declaration for writable Environment managers.cloudflare/sandbox:0.12.3to its current digest so base image content is reproducible.EXPECTED_*version arguments and no globalPIP_*runtime environment variables.Review
apt,cargo,gem, andgoare deliberately absent; Mosoo #340 owns legacy read compatibility and migration errors.