feat(web): redesign Files page filters with custom Select component#295
Open
Yevanchen wants to merge 2 commits into
Open
feat(web): redesign Files page filters with custom Select component#295Yevanchen wants to merge 2 commits into
Yevanchen wants to merge 2 commits into
Conversation
Replace the native <select> elements in the Files page toolbar with a shared Select component built on the Base UI Select primitive. The new component matches the app design tokens (card surface, strong border, popover shadow) and adds a chevron trigger icon, check indicator on the selected item, keyboard navigation, and truncation for long thread titles.
Filter controls kept fixed desktop widths when the toolbar wrapped on narrow viewports, leaving ragged left-aligned rows. Controls now stack full-width below the sm breakpoint (segmented buttons distribute evenly), grow to fill wrapped rows between sm and lg, and keep the original compact layout from lg up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fill what changed. Use N/A for irrelevant or maintainer-only items. See
CONTRIBUTING.mdfor branch, CLA, generated file, and CI rules.Summary
Selectcomponent (apps/web/src/shared/ui/select.tsx) built on the Base UISelectprimitive, styled with the app design tokens (card surface,border-border-strong, popover shadow, check indicator, chevron icon).<select>elements in the Files page filter toolbar (Agent filter, Thread filter) with the new component; long thread titles now truncate in both the trigger and the popup.Why
Verification
bun run fmt,bun run lint,bun run tc,bun run test(140 pass) inapps/web.Impact
Review
apps/web/src/shared/ui/select.tsx(new component), Files page toolbar wiring inapps/web/src/routes/files/files.route.tsx.cost-agents-panel.tsx) still uses a native<select>; migrating it is left as a follow-up to keep this change scoped.