MPI performance updates and Kernel naming#158
Open
jacob-moore22 wants to merge 12 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does 2 things, first, it attempts to improve the "safety" of the mpi types. MPI send/recv bookkeeping that was previously flat data members on MPICArrayKokkos is consolidated into a dedicated host-side buffer object, accessed through a Kokkos host view. This involved a few method updates to make the new access pattern work.
Second, it adds naming to the FOR_/DO_/RUN_* kernels. This optional trailing kernel name support to MATAR's top-level Kokkos parallel macros. When provided, the name is forwarded as the first argument to Kokkos::parallel_for / Kokkos::parallel_reduce, enabling Kokkos Tools, NVTX, rocprofiler, VTune, and similar profilers to attribute kernels with human-readable labels. When omitted, behavior is unchanged (Kokkos already defaults unnamed kernels to "").
Backward compatibility: All existing call sites compile and run unchanged. The name is purely optional.
Also, I added lots of unit test for the macros that now get ran with everything else.
Still lots of testing to do, namely with MPI and CUDA.