Modify evaluation of absorption coefficients#63
Merged
Conversation
Yurlungur
approved these changes
Jan 17, 2025
Collaborator
Yurlungur
left a comment
Yurlungur
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the cleanup! Yes let's discuss the larger picture changes together at some later date.
| const RadiationType type, const Real nu, | ||
| Real *lambda = nullptr) const { | ||
| return dist_.AbsorptionCoefficientFromKirkhoff(*this, rho, temp, Ye, type, | ||
| return dist_.AbsorptionCoefficientFromKirchhoff(*this, rho, temp, Ye, type, |
Collaborator
There was a problem hiding this comment.
oops thank you for the spelling fix...
| Real *lambda = nullptr) const { | ||
| return dist_.AbsorptionCoefficientFromKirkhoff(*this, rho, temp, nu, | ||
| lambda); | ||
| return rho * kappa_; |
Collaborator
I agree with this choice
I think it's maybe worth editing those down the line but no need to change it here. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR originally started much larger---actually changing all calls from
AbsorptionCoefficienttoSpecificAbsorptionOpacity. After some retrospection, a simple change of mindset got me on board with instead dealing with absorption coefficients. I'd like to discuss this via meeting.After this realization, this PR shrunk to only changing out some calls to
AbsorptionCoefficientto directly returning rho * kappa (where rho is the material density and kappa is the material specific absorption opacity), instead of arriving there via Kirchhoff's laws.I kept the functions for
*FromKirchhoffin this PR for photons, even though they are not used, as I think they do help guide readers of the code as to what things correspond to. Neutrinos also have calls to*FromKirchhoff(e.g., for the tophat absorption coefficient), but I did not edit these (was this the right move?).