Make slight tweaks for Debug builds.#66
Conversation
+ Modify memcmp usage in == overload comparing physical constants. + Update spiner submodule for fix of a recently added assert.
|
@Yurlungur would it be reasonable to convert the bit-wise comparison in the overload to comparing the member data with tolerances (to permit, e.g. 1e-15 differences in units)? Or is that maybe not in the spirit of this comparison? |
I think that would be fine. The current implementation is just laziness on my part I think. |
Will make that change quickly here then - thanks! |
+ Add eps_equal private function to struct (formula from unit tests). + Use macro EPS value, similar to opacity classes.
|
Just made the eps-comparison modification (the memcmp is much more succinct). |
Description
Testing with a Debug build of a dependent code revealed a comparison of the same constants throws an assertion.
Changes